Skip to content

Conversation

@thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Dec 6, 2018

Summary

  • prepare for 2.1.4 patch release wrapping load file in try/catch.

The "why", or other context.

Test plan

Issues

There was a crash reported here effecting a very small group.

@thomaszurkan-optimizely thomaszurkan-optimizely changed the title update changelog for patch release chore: update changelog for patch release Dec 6, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely changed the title chore: update changelog for patch release (chore): update changelog for patch release Dec 6, 2018
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 733faa5 into master Dec 6, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the prepare2.1.4 branch December 6, 2018 22:16
thomaszurkan-optimizely added a commit that referenced this pull request Dec 7, 2018
* have the buffer reader call wrapped in a try catch in case of exception (#241)

* update changelog for patch release (#244)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants