Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore):Fix2.1.5 #245

Merged
merged 2 commits into from
Dec 7, 2018
Merged

(chore):Fix2.1.5 #245

merged 2 commits into from
Dec 7, 2018

Conversation

thomaszurkan-optimizely
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely commented Dec 6, 2018 •
edited
Loading

Summary

  • Fix for possible problem loading file from static variable initializer.

The "why", or other context.

Test plan

Issues

@thomaszurkan-optimizely thomaszurkan-optimizely changed the title Fix2.1.5 (chore):Fix2.1.5 Dec 6, 2018
@mikeproeng37
Copy link
Contributor

build-e2e

mikeproeng37
mikeproeng37 approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 921e0d9 into 2.1.x Dec 7, 2018
@thomaszurkan-optimizely thomaszurkan-optimizely deleted the fix2.1.5 branch December 7, 2018 05:42
@coveralls
Copy link

coveralls commented Dec 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 789

  • 6 of 6 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 89.253%
Totals Coverage Status
Change from base Build 643: 0.008%
Covered Lines: 2342
Relevant Lines: 2624
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomaszurkan-optimizely @mikeproeng37 @coveralls