-
Notifications
You must be signed in to change notification settings - Fork 83
global export #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for bringing this up @jasonkarns. I've created an item on our backlog to address this for the next release. |
Cool! In the interim, could you share exactly what the exported variable name actually is? |
We actually aren't exporting it globally. This is something we missed in our implementation, sorry! The only way to use it currently would be via CommonJS. We'll be working on exposing a global variable soon. |
How is that possible? Webpack defaults to exporting via global variable if And your current webpack config clearly does not set javascript-sdk/webpack.config.js Lines 21 to 24 in 7e1398c
|
I believe because we do not have the I have a PR open for this: #18 |
…lable' (#14) Summary: This changes the behavior of the `onReady` Promise to align with the Java implementation. The `onReady` Promise is now resolved as soon as the datafile manager has any datafile (whether it was passed in or fetched). An update event is always emitted when the datafile changes after `onReady`. Test plan: Updated unit tests
Uh oh!
There was an error while loading. Please reload this page.
I see that the SDK compiles a browser distributable via webpack. However, I don't see what the globally exported variable name is for the distributable. Unfortunately none of the docs show usage other than
require(...
which isn't helpful.More specifically, if webpack's configuration option
output.library
were set explicitly, this variable name would be abundantly clear.The text was updated successfully, but these errors were encountered: