Add global export variable #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace bluebird dependency with smaller es6-promise library.
Update contribution doc to use CLA
Bump version to 1.0.0
Summary: This is needed for us to set up in Bower and have the SDK pulled in as a snippet. Test Plan: Unit and manual Reviewers: #oasis_team_review Differential Revision: https://phabricator.optimizely.com/D13788
Add global variable export for use in non CommonJS environments
Fix branch conflicts
haleybash-optimizely
approved these changes
Nov 14, 2016
Closed
jasonkarns
reviewed
Nov 14, 2016
| "main": "index.js", | ||
| "scripts": { | ||
| "test": "./node_modules/.bin/mocha ./tests.js", | ||
| "build": "webpack index.js dist/optimizely.min.js", |
There was a problem hiding this comment.
I'd suggest changing this to: "build": "webpack $npm_package_main dist/optimizely.min.js", so as to reduce the duplicate knowledge of the entrypoint. This way main is the canonical location for defining the entrypoint and the build script doesn't need tweaked if the entrypoint is moved.
|
Seems that with the removal of the json-loader from the webpack config, it can be removed as a devDep, as well. |
|
Thanks for the suggestions @jasonkarns . Will address those in a PR into the devel branch as it would just delay this PR. |
mjc1283
added a commit
that referenced
this pull request
Apr 22, 2019
Summary: Before this change, we were passing the host property returned from url.parse as the host option going into http.request (or https.request). The host property from url.parse includes the port when the URL contains a port. The problem is, request needs port to be passed as a separate option (not included as part of the host option). To fix, stop passing host, and replace it with hostname: url.hostname (where url.hostname excludes port), and port: url.port. References: https://nodejs.org/api/http.html#http_http_request_url_options_callback https://nodejs.org/api/url.html#url_urlobject_host https://nodejs.org/api/url.html#url_urlobject_hostname https://nodejs.org/api/url.html#url_urlobject_port Test plan: Added a regression test. Manually tested in @mikeng13's prototype datafile management branches for JS-testapp and compatibility suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@optimizely/fullstack-devs
Fixes #14