feat(api): Feature variable APIs now return default variable value when featureEnabled property is false. #249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjc1283
suggested changes
Mar 28, 2019
| ) | ||
| ); | ||
| var value = projectConfig.getVariableValueForVariation(this.configObj, variable, decision.variation, this.logger); | ||
| if (value) { |
There was a problem hiding this comment.
Should this be value !== null? What if value is an empty string?
mjc1283
reviewed
Mar 28, 2019
| @@ -519,7 +519,8 @@ module.exports = { | |||
|
|
|||
| var variableUsages = projectConfig.variationVariableUsageMap[variation.id]; | |||
| var variableUsage = variableUsages[variable.id]; | |||
| return variableUsage ? variableUsage.value : variable.defaultValue; | |||
|
|
|||
| return variableUsage ? variableUsage.value : null; | |||
There was a problem hiding this comment.
The doc comment for this function is now incorrect, given this change.
…nto fahad/feature-enable-checking
|
build |
mjc1283
approved these changes
Mar 28, 2019
|
@jordangarcia are u going to review this PR? |
|
@msohailhussain can you address conflict. I can merge right after. |
…e-checking # Conflicts: # packages/optimizely-sdk/lib/optimizely/index.js
|
@aliabbasrizvi Conflicts resolved. Please take a look again. |
…nto fahad/feature-enable-checking
|
@msohailhussain can you address conflicts |
…e-checking # Conflicts: # packages/optimizely-sdk/lib/core/decision_service/index.tests.js # packages/optimizely-sdk/lib/optimizely/index.js
jordangarcia
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan