-
Notifications
You must be signed in to change notification settings - Fork 83
feat(api): Feature variable APIs now return default variable value when featureEnabled property is false. #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d464e51
Feature variable APIs now return default variable value when featureE…
mfahadahmed 9612b9c
Feature variable APIs now return default variable value when featureE…
mfahadahmed d9b647f
Added separate log message when variable is not used in variation.
mfahadahmed 947e321
Merge remote-tracking branch 'origin/master' into fahad/feature-enabl…
mfahadahmed c252a60
Merge remote-tracking branch 'origin/fahad/feature-enable-checking' i…
mfahadahmed 8a2158c
Addressed code review comments.
mfahadahmed c5e6724
Merge remote-tracking branch 'origin/master' into fahad/feature-enabl…
mfahadahmed de683ab
Merge remote-tracking branch 'origin/fahad/feature-enable-checking' i…
mfahadahmed afa95b2
Merge remote-tracking branch 'origin/master' into fahad/feature-enabl…
mfahadahmed 47b48f9
Merge remote-tracking branch 'origin/master' into fahad/feature-enabl…
mfahadahmed File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The doc comment for this function is now incorrect, given this change.