Skip to content

fix: Allow logLevel to support string type to avoid compiler type error #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 18, 2020
Merged

fix: Allow logLevel to support string type to avoid compiler type error #627

merged 3 commits into from
Nov 18, 2020

Conversation

yavorona
Copy link
Contributor

Summary

Allow logLevel to support string type in addition to LogLevel enum to avoid compiler type error

Test plan

Existing unit tests

Issues

SDK-issue 614

@yavorona yavorona requested a review from a team as a code owner November 18, 2020 20:14
@coveralls
Copy link

coveralls commented Nov 18, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 96.71% when pulling 0099320 on pnguen/fix-logLevel-type into 1c25d23 on master.

@yavorona yavorona removed their assignment Nov 18, 2020
@yavorona yavorona merged commit f519711 into master Nov 18, 2020
@yavorona yavorona deleted the pnguen/fix-logLevel-type branch November 18, 2020 21:55
@yavorona yavorona mentioned this pull request Nov 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjc1283 mjc1283 mjc1283 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yavorona @coveralls @mjc1283