fix: Change experimentKey and variationKey to be null in rollout in decisionInfo payload #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsistent with other sdks
yavorona
changed the title
mjc1283
approved these changes
Jan 22, 2021
Comment on lines
-1499
to
-1500
| const experimentKey = decision.getExperimentKey(decisionObj); | ||
| const variationKey = decision.getVariationKey(decisionObj); |
There was a problem hiding this comment.
Are getExperimentKey & getVariationKey methods no longer used, so should delete them?
There was a problem hiding this comment.
These methods are being used in buildImpressionEvent and emitNotificationCenterActivate methods (we are still sending rule_key and variation_key as empty strings inside metadata object in this case). I am not sure if they should be changed to null. @jaeopt maybe you have any thought on that?
There was a problem hiding this comment.
@yavorona I think we should keep those. Event and notification will have different requirements (empty string instead of null) than optimizelyDecision (null).
yavorona
force-pushed
the
pnguen/run-fsc-tests
branch
from
aaafbd5 to
89bc241
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
variationKeyandruleKeyfrom empty string tonullin a rolloutdecisionInfopayload in order to pass FSC tests.OptimizelyDecideOptionsenums toOptimizelyDecideOptionto be consistent with other SDKs.Test plan
uzair/decide-api-endpointstestapp branch - all pass except for DECIDE WORLD tests, which will be addressed separately