Fixes an issue where bridging an Objective-C type called Optional into a Swift-based project causes LLDB issues #274
Conversation
…es LLDB to sometimes not be able to distinguish between Swift.Optional and OptimizelySDKiOS.Optional.
|
I've also made a bug report here. |
tprevost-phunware
changed the title
tprevost-phunware
changed the title
|
Actually, this may not be needed anymore since the Swift LLDB team has apparently fixed this issue here: apple/swift-lldb#750 |
There was a problem hiding this comment.
@tprevost-phunware thank you so much for your contribution. I would have made the same change. Can you please sign this and I will merge your changes?
https://docs.google.com/a/optimizely.com/forms/d/e/1FAIpQLSf9cbouWptIpMgukAKZZOIAhafvjFCV8hS00XJLWQnWDFtwtA/viewform
|
@thomaszurkan-optimizely Sure thing. Done! |
|
Can one of the admins verify this patch? |
* master: update changelog for new release (#322) add test script and fix broken carthage build (#321) Prepare for2.1.1 (#318) add EventTagUtil to universal project (#314) Fix an issue where importing an Objective-C type called Optional causes LLDB to sometimes not be able to distinguish between Swift.Optional and OptimizelySDKiOS.Optional. (#274) remove unused protocol (#313) fix(whitelisting): Invalid whitelisted variation stops bucketing (#308)
|
@tprevost-phunware Thanks for the patch to the Optimizely Objective-C SDK! Hopefully it's now a bit easier to use for the Swift projects out there. Feel free to reach out to me at asa@optimizely.com if you are at all interested in joining Optimizely full-time! |
|
No prob, @asaschachar! Glad I could help! Yeah I'll see if we can update to the latest version of the Optimizely SDK on our project (we're still on 1.5.0 unfortunately) to see this fix in action! Oh and thanks for the offer! I'm not looking for a job at the moment, but I'll keep Optimizely in mind for the future! :) |
I've found that bridging an Objective-C protocol called
Optionalinto a Swift-based project causes LLDB to sometimes not be able to distinguish between Optimizely'sOptionalandSwift.Optional. For example, if you set a breakpoint inside a closure, then addto the closure, then hit the breakpoint during execution and try to
poanything in the debugger, you'll get this:This PR simply renames
OptionaltoOPTLYOptional, which I have found fixes the issue.I tried using
NS_SWIFT_NAME(OPTLYOptional), but that still causes LLDB to spit out errors like the above, becauseNS_SWIFT_NAME(OPTLYOptional)seems to only create a typealias for Optimizely'sOptionaltype and does not actually replace the name at all.Have I run all the tests to make sure they still pass? Yes. Well, the OptimizelySDKCoreiOS and OptimizelySDKiOS tests at least. I couldn't find a way to just run all the tests. I tried some of the tvOS tests, but they wouldn't even build, saying they could not find the file
<OptimizelySDKShared/OPTLYDatafileConfig.h>. 😕