Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(whitelisting): Invalid whitelisted variation stops bucketing #308

Merged
merged 4 commits into from
Sep 24, 2018
Merged

fix(whitelisting): Invalid whitelisted variation stops bucketing #308

merged 4 commits into from
Sep 24, 2018

Conversation

AbdurRafay
Copy link
Contributor

Summary

  • OPTLYDecisionService only returns valid whitelisted variations otherwise bucketed variations.

@arafay-folio3
refactor(EventBuilder): Moved decision service and bucketing from Eve…
8efe0eb 
…ntBuilder to Optimizely (#307)

* Send decisions for all experiments using an event

* nits

* accept tags as event tags even if not convertible to revenue or value tag

* Optimizely refactored

* make projectConfig a private property of EventBuilder instead passing it to every method

* impression event refactored

* track and conversion refactored

* test cases

* fixed test cases

* Optimizely coverage increased

* EventBuilder coverage increased

* LoggerMessages refactored

* removed params validation from eventBuilder methods, 
updated license headers, 
removed unused loggerMessages
@arafay-folio3
fix(whitelisting): Invalid whitelisted variation stops bucketing
5465933
@msohailhussain
Copy link
Contributor

This PR contains bucket refactoring code as wel. Once it is merged, we'll rebase with master.

@msohailhussain
Copy link
Contributor

build

arafay-folio3 and others added 2 commits September 21, 2018 16:23
@arafay-folio3 @msohailhussain
fix(whitelisting): Invalid whitelisted variation stops bucketing
23d41ae
@msohailhussain
Merge branch 'arafay/invalid-whitelisted-variation' of github.com:opt…
984ded8 
…imizely/objective-c-sdk into arafay/invalid-whitelisted-variation

# Conflicts:
#	OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.h
#	OptimizelySDKCore/OptimizelySDKCore/OPTLYEventBuilder.m
#	OptimizelySDKCore/OptimizelySDKCore/Optimizely.m
#	OptimizelySDKCore/OptimizelySDKCoreTests/OPTLYEventBuilderTest.m
@msohailhussain msohailhussain changed the base branch from master to notification/Example September 21, 2018 23:34
@msohailhussain msohailhussain changed the base branch from notification/Example to master September 21, 2018 23:35
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 29.607% when pulling 984ded8 on arafay/invalid-whitelisted-variation into f308d68 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 29.607% when pulling 984ded8 on arafay/invalid-whitelisted-variation into f308d68 on master.

thomaszurkan-optimizely
thomaszurkan-optimizely approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@thomaszurkan-optimizely thomaszurkan-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit e43f2a6 into master Sep 24, 2018
AbdurRafay pushed a commit that referenced this pull request Oct 1, 2018
@arafay-folio3
Merge branch 'master' into arafay/attributes-type
994c6ba 
* master:
  update changelog for new release (#322)
  add test script and fix broken carthage build (#321)
  Prepare for2.1.1 (#318)
  add EventTagUtil to universal project (#314)
  Fix an issue where importing an Objective-C type called Optional causes LLDB to sometimes not be able to distinguish between Swift.Optional and OptimizelySDKiOS.Optional. (#274)
  remove unused protocol (#313)
  fix(whitelisting): Invalid whitelisted variation stops bucketing (#308)
@yasirfolio3 yasirfolio3 deleted the arafay/invalid-whitelisted-variation branch January 21, 2019 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaszurkan-optimizely thomaszurkan-optimizely thomaszurkan-optimizely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AbdurRafay @msohailhussain @coveralls @thomaszurkan-optimizely @arafay-folio3