fix(dispatch): Updating default event dispatcher to actually raise exceptions #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliabbasrizvi
changed the title
|
build-e2e |
nchilada
reviewed
Mar 1, 2019
| requests.post( | ||
| event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT | ||
| ).raise_for_status() | ||
|
|
||
| except request_exception.RequestException as error: |
There was a problem hiding this comment.
It looks like this would catch any requests.HTTPError, which makes me wonder whether the PR is titled correctly. At the very least, I would describe it in the release notes as "Updated the default event dispatcher to log an error if the request resolves to HTTP 4xx or 5xx" (per https://github.com/kennethreitz/requests/blob/bedd9284c9646e50c10b3defdf519d4ba479e2c7/requests/models.py#L933-L940).
@aliabbasrizvi what do you think?
There was a problem hiding this comment.
And by the way, should we consider calling the customer's error handler as well?
Or should we actually raise upon certain kinds of errors? Instead of catching and logging from within the default event dispatcher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue raised here