Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dispatch): Updating default event dispatcher to actually raise exceptions #140

Merged
merged 1 commit into from
Aug 29, 2018
Merged

fix(dispatch): Updating default event dispatcher to actually raise exceptions #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions optimizely/event_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,11 @@ def dispatch_event(event):

try:
if event.http_verb == enums.HTTPVerbs.GET:
requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT)
requests.get(event.url, params=event.params, timeout=REQUEST_TIMEOUT).raise_for_status()
elif event.http_verb == enums.HTTPVerbs.POST:
requests.post(event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT)
requests.post(
event.url, data=json.dumps(event.params), headers=event.headers, timeout=REQUEST_TIMEOUT
).raise_for_status()

except request_exception.RequestException as error:
Copy link
Contributor

@nchilada nchilada Mar 1, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this would catch any requests.HTTPError, which makes me wonder whether the PR is titled correctly. At the very least, I would describe it in the release notes as "Updated the default event dispatcher to log an error if the request resolves to HTTP 4xx or 5xx" (per https://github.com/kennethreitz/requests/blob/bedd9284c9646e50c10b3defdf519d4ba479e2c7/requests/models.py#L933-L940).

@aliabbasrizvi what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And by the way, should we consider calling the customer's error handler as well?

Or should we actually raise upon certain kinds of errors? Instead of catching and logging from within the default event dispatcher.

logging.error('Dispatch event failed. Error: %s' % str(error))