Update Box in TrialListDetail scrollable #456
Conversation
| @@ -226,10 +226,13 @@ const TrialListDetail: FC<{ | |||
| ? "rgba(255, 255, 255, 0.05)" | |||
| : "rgba(0, 0, 0, 0.05)", | |||
| width: "100%", | |||
| maxWidth: "1000px", | |||
There was a problem hiding this comment.
How about removing this for wide display users?
| maxWidth: "1000px", |
There was a problem hiding this comment.
@c-bata Thanks comment!
Without a maximum width setting, the window will be as wide as the length of the string.
I'm trying to fix a problem with a Human-in-the-loop Slider widget where the width of the slider is lengthened to match the length of the string.(see Horizontal scrolling part of the issue)
So I would like to remove the maximum width in the section you commented on, and add a maximum value to the slider width.
what do you think?
There was a problem hiding this comment.
It is intended to add maxWidth:"1000px" to the following.
https://github.com/optuna/optuna-dashboard/blob/main/optuna_dashboard/ts/components/TrialFormWidgets.tsx#L141
The following modifications are intended
There was a problem hiding this comment.
So I would like to remove the maximum width in the section you commented on, and add a maximum value to the slider width. what do you think?
@hrntsm Thank you for your explanation. Sounds reasonable!
| @@ -385,6 +386,7 @@ const ReadonlyFormWidgets: FC<{ | |||
| marginBottom: theme.spacing(2), | |||
| margin: theme.spacing(0, 1, 1, 0), | |||
| p: theme.spacing(1), | |||
| maxWidth: "1000px", | |||
There was a problem hiding this comment.
@c-bata
I added a maxWidth setting so that it is the same size for Readonly widgets that have completed their evaluation, not just Updatable ones that have an evaluation in them.
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Fix #448
What does this implement/fix? Explain your changes.
The content mentioned in the above issue has been modified as shown in the following image.
In order to enable horizontal scrolling, maxWidth is set to 1000px for now, but the value will be modified if wider is better, etc.
The maximum height is set to 150px, but I just made sure that about 6 lines are displayed, and will modify this one if necessary.
If "alignItems" is set to "center", values above the center will not be displayed when vertical scrolling is enabled. Therefore, it is removed.
The result is that each value is not centered but slightly above the center.