Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Box in TrialListDetail scrollable #456

Merged
merged 2 commits into from
May 17, 2023
+5 −1
Merged

Update Box in TrialListDetail scrollable #456

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9c4ccc
Update Box in TrialListDetail scrollable
hrntsm May 10, 2023
3b14ebd
Add maxWidth setting to UpdatableFormWidget.
hrntsm May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions optuna_dashboard/ts/components/TrialFormWidgets.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ const UpdatableFormWidgets: FC<{
marginBottom: theme.spacing(2),
margin: theme.spacing(0, 1, 1, 0),
p: theme.spacing(1),
maxWidth: "1000px",
}}
>
{widgetStates.map((ws) => ws.render())}
Expand Down Expand Up @@ -385,6 +386,7 @@ const ReadonlyFormWidgets: FC<{
marginBottom: theme.spacing(2),
margin: theme.spacing(0, 1, 1, 0),
p: theme.spacing(1),
maxWidth: "1000px",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@c-bata
I added a maxWidth setting so that it is the same size for Readonly widgets that have completed their evaluation, not just Updatable ones that have an evaluation in them.

}}
>
{formWidgets.widgets.map((widget, i) => {
Expand Down
4 changes: 3 additions & 1 deletion optuna_dashboard/ts/components/TrialList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,12 @@ const TrialListDetail: FC<{
? "rgba(255, 255, 255, 0.05)"
: "rgba(0, 0, 0, 0.05)",
width: "100%",
maxHeight: "150px",
overflow: "auto",
p: theme.spacing(0.5, 1),
borderRadius: theme.shape.borderRadius * 0.2,
display: "flex",
alignItems: "center",
whiteSpace: "nowrap",
}}
>
{value}
Expand Down