Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance delete artifacts APIs and add tests for them #752

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

y0z
Copy link
Member

@y0z y0z commented Jan 15, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

None

What does this implement/fix? Explain your changes.

  • Add tests for delete study/trial artifacts APIs
  • Make delete study/trial artifacts APIs to be able to properly handle the ArtifactNotFound exception, i.e., returning 404 rather than causing internal server error

Copy link

codecov bot commented Jan 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (616f08c) 68.20% compared to head (99a54cb) 68.81%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   68.20%   68.81%   +0.60%     
==========================================
  Files          35       35              
  Lines        2334     2344      +10     
==========================================
+ Hits         1592     1613      +21     
+ Misses        742      731      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@contramundum53 contramundum53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution.

@c-bata c-bata merged commit 79f4665 into optuna:main Jan 16, 2024
13 checks passed
@y0z y0z deleted the feature/enhance_delete_artifacts branch January 16, 2024 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants