Enhance delete artifacts APIs and add tests for them

optuna_dashboard/artifact/_backend.py

@@ -181,10 +181,16 @@ def upload_study_artifact_api(study_id: int) -> dict[str, Any]:
     @app.delete("/api/artifacts/<study_id:int>/<trial_id:int>/<artifact_id:re:[0-9a-fA-F-]+>")
     @json_api_view
     def delete_trial_artifact(study_id: int, trial_id: int, artifact_id: str) -> dict[str, Any]:
+        from optuna.artifacts.exceptions import ArtifactNotFound
+
         if artifact_store is None:
             response.status = 400  # Bad Request
             return {"reason": "Cannot access to the artifacts."}
-        artifact_store.remove(artifact_id)
+        try:
+            artifact_store.remove(artifact_id)
+        except ArtifactNotFound as e:
+            response.status = 404
+            return {"reason": str(e)}
 
         # The artifact's metadata is stored in one of the following two locations:
         storage.set_study_system_attr(
@@ -200,10 +206,16 @@ def delete_trial_artifact(study_id: int, trial_id: int, artifact_id: str) -> dic
     @app.delete("/api/artifacts/<study_id:int>/<artifact_id:re:[0-9a-fA-F-]+>")
     @json_api_view
     def delete_study_artifact(study_id: int, artifact_id: str) -> dict[str, Any]:
+        from optuna.artifacts.exceptions import ArtifactNotFound
+
         if artifact_store is None:
             response.status = 400  # Bad Request
             return {"reason": "Cannot access to the artifacts."}
-        artifact_store.remove(artifact_id)
+        try:
+            artifact_store.remove(artifact_id)
+        except ArtifactNotFound as e:
+            response.status = 404
+            return {"reason": str(e)}
 
         storage.set_study_system_attr(
             study_id, ARTIFACTS_ATTR_PREFIX + artifact_id, json.dumps(None)

python_tests/artifact/test_backend.py

@@ -249,3 +249,52 @@ def test_upload_artifact() -> None:
         with open(f"{tmpdir}/{res['artifact_id']}", "r") as f:
             data = f.read()
             assert data == "dummy_content"
+
+
+def test_delete_study_artifact() -> None:
+    storage = optuna.storages.InMemoryStorage()
+    study = optuna.create_study(storage=storage)
+    with tempfile.TemporaryDirectory() as tmpdir:
+        artifact_store = FileSystemArtifactStore(tmpdir)
+        with tempfile.NamedTemporaryFile() as f:
+            f.write(b"dummy_content")
+            f.flush()
+            artifact_id = upload_artifact(study, f.name, artifact_store=artifact_store)
+        app = create_app(storage, artifact_store)
+        status, _, _ = send_request(
+            app,
+            f"/api/artifacts/{study._study_id}/{artifact_id}",
+            "DELETE",
+        )
+        assert status == 204
+        status, _, _ = send_request(
+            app,
+            f"/api/artifacts/{study._study_id}/{artifact_id}",
+            "DELETE",
+        )
+        assert status == 404
+
+
+def test_delete_trial_artifact() -> None:
+    storage = optuna.storages.InMemoryStorage()
+    study = optuna.create_study(storage=storage)
+    trial = study.ask()
+    with tempfile.TemporaryDirectory() as tmpdir:
+        artifact_store = FileSystemArtifactStore(tmpdir)
+        with tempfile.NamedTemporaryFile() as f:
+            f.write(b"dummy_content")
+            f.flush()
+            artifact_id = upload_artifact(trial, f.name, artifact_store=artifact_store)
+        app = create_app(storage, artifact_store)
+        status, _, _ = send_request(
+            app,
+            f"/api/artifacts/{study._study_id}/{trial._trial_id}/{artifact_id}",
+            "DELETE",
+        )
+        assert status == 204
+        status, _, _ = send_request(
+            app,
+            f"/api/artifacts/{study._study_id}/{trial._trial_id}/{artifact_id}",
+            "DELETE",
+        )
+        assert status == 404