Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analytics plot backend #778

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Analytics plot backend #778

merged 6 commits into from
Feb 2, 2024

Conversation

knshnb
Copy link
Member

@knshnb knshnb commented Jan 26, 2024

Contributor License Agreement

This repository (optuna-dashboard) and Goptuna share common code.
This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.

  • I agree this patch may be ported to Goptuna by other Goptuna contributors.

Reference Issues/PRs

Apply #764 to other graphs in the analytics page.

What does this implement/fix? Explain your changes.

Analytics page:

  • slice (this PR)
  • parallel_coordinate (this PR)
  • contour
  • rank (this PR)
  • edf

Let me work on edf by another PR because I need to support multi-study plot for GraphEdf.

@knshnb knshnb mentioned this pull request Jan 26, 2024
1 task
@knshnb knshnb changed the base branch from main to AtomsArtifactViewer January 26, 2024 10:35
@knshnb knshnb changed the base branch from AtomsArtifactViewer to main January 26, 2024 10:35
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

Attention: 10 lines in your changes are missing coverage. Please review.

Comparison is base (aef91de) 69.38% compared to head (b2756fd) 69.13%.
Report is 55 commits behind head on main.

Files Patch % Lines
optuna_dashboard/_app.py 10.00% 9 Missing ⚠️
optuna_dashboard/artifact/_backend.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
- Coverage   69.38%   69.13%   -0.25%     
==========================================
  Files          35       35              
  Lines        2368     2378      +10     
==========================================
+ Hits         1643     1644       +1     
- Misses        725      734       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-bata c-bata self-assigned this Jan 29, 2024
Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your pull request. Changes basically look good to me. However, I noticed a minor issue that the width of some graph components is wider than screen width.

Screenshot 2024-02-01 18 13 01

Would you like to address this issue in this PR, or would you prefer to resolve it in following pull requests?

@knshnb
Copy link
Member Author

knshnb commented Feb 2, 2024

@c-bata Thanks for pointing it out! I fixed the issue by forcing the auto-resizing for the slice plot generated by optuna.visualization.

Copy link
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let me merge this PR after passing CI.

@c-bata c-bata merged commit a728501 into optuna:main Feb 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants