Support backend rendering of plots in the top page #805
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #805 +/- ##
==========================================
- Coverage 69.71% 69.53% -0.18%
==========================================
Files 35 35
Lines 2364 2370 +6
==========================================
Hits 1648 1648
- Misses 716 722 +6 ☔ View full report in Codecov by Sentry. |
| getPlotAPI(studyId, PlotType.ParamImportances) | ||
| .then(({ data, layout }) => { | ||
| plotly.react(plotDomId, data, layout) | ||
| }) | ||
| .catch((err) => { | ||
| console.error(err) | ||
| }) |
There was a problem hiding this comment.
To avoid calling the API directly in useEffect, a new hook usePlot has been introduced (optuna_dashboard/ts/hooks/usePlot.ts).
Could you change the implementation to use this? (FYI, see the implementation of optuna_dashboard/ts/components/GraphContour.tsx)
There was a problem hiding this comment.
Thanks, I applied this change: 4ceeb1b
| {" "} | ||
| <div id={plotDomId} />{" "} |
There was a problem hiding this comment.
Good catch, thank you! 9256a1b
|
@knshnb Thank you for your PR! |
|
Thanks for the review! I updated the PR. |
Contributor License Agreement
This repository (
optuna-dashboard) and Goptuna share common code.This pull request may therefore be ported to Goptuna.
Make sure that you understand the consequences concerning licenses and check the box below if you accept the term before creating this pull request.
Reference Issues/PRs
Top page version of #778
What does this implement/fix? Explain your changes.
This PR supports the backend rendering of the following three plots.
We need to discuss how to handle
includePrunedandlogScaleargs to address history and intermediate values plots.