Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata for Netty KQueue transport #379

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Add metadata for Netty KQueue transport #379

merged 2 commits into from
Oct 4, 2023

Conversation

violetagg
Copy link
Contributor

What does this PR do?

This PR adds metadata for Netty KQueue transport.
Netty KQueue transport can be used by the users that are on Mac OS and do not want to use Java NIO transport. (similar to Epoll transport for Linux)

Code sections where the PR accesses files, network, docker or some external service

N/A

Checklist before merging

Test is not provided because the fix is relevant only for Mac OS.

Netty KQueue transport can be used by those that are on Mac OS
and do not want to use Java NIO transport. (similar to Epoll transport for Linux)
@violetagg violetagg requested a review from a team as a code owner September 1, 2023 18:36
@violetagg violetagg requested a review from melix September 1, 2023 18:36
@violetagg
Copy link
Contributor Author

@sdeleuze PTAL

Copy link
Collaborator

@bclozel bclozel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there aren't any new tests, but those code paths are only involved on macOS systems.
So 👍

violetagg added a commit to reactor/reactor-netty that referenced this pull request Sep 13, 2023
Temporary add the missing GraalVM metadata to the test as the PRs below are still in progress
oracle/graalvm-reachability-metadata#379
oracle/graalvm-reachability-metadata#382
violetagg added a commit to reactor/reactor-netty that referenced this pull request Sep 13, 2023
Temporary add the missing GraalVM metadata to the test as the PRs below are still in progress
oracle/graalvm-reachability-metadata#379
oracle/graalvm-reachability-metadata#382
@dnestoro dnestoro merged commit 0e3ba19 into oracle:master Oct 4, 2023
6 checks passed
@violetagg
Copy link
Contributor Author

@dnestoro Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants