-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata for Netty SelectorProviderUtil #382
Conversation
Temporary add the missing GraalVM metadata to the test as the PRs below are still in progress oracle/graalvm-reachability-metadata#379 oracle/graalvm-reachability-metadata#382
Temporary add the missing GraalVM metadata to the test as the PRs below are still in progress oracle/graalvm-reachability-metadata#379 oracle/graalvm-reachability-metadata#382
Can't you use |
@czp3009 is there a plan to work on this PR? Have you tried |
I suppose that the better place is https://github.com/netty/netty - they already have graal-related metadata https://github.com/netty/netty/issues?q=graal |
That would be even better! |
hi @dnestoro , i was also trying to add metadata to Netty repository, but that doesn't solve the problem. please see following issue: netty/netty#13575 After discussing with the Netty repository manager, i was decided to commit the metadata to this repository. I am very sorry for not submitting test case code for a long time, but I've been really busy lately, and I'm not familiar with test cases like this. I'm not sure when I'll have time to do this PR, at least not in the near future. |
@dnestoro The tests below should validate this change.
|
@czp3009 Can you please update your PR with the tests proposed by @violetagg ? |
Thanks! |
What does this PR do?
Add reflection hints for Netty SelectorProviderUtil
Netty code in
io.netty.channel.socket.nio.SelectorProviderUtil
:If Java version higher than or equals to 15,
SelectorProviderUtil
may invokejava.nio.channels.spi.SelectorProvide
by reflection.SelectorProviderUtil.findOpenMethod
will be called in two Netty class:NioSocketChannel
andNioServerSocketChannel
corresponding to twoSelectorProvider
methods:openSocketChannel
andopenServerSocketChannel
.This PR add metadata for them.
Code sections where the PR accesses files, network, docker or some external service
None
Checklist before merging