chore: improve token support in run_macaron.sh #780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
tromai
changed the title
tromai
changed the title
tromai
changed the title
tromai
changed the title
tromai
force-pushed
the
tromai/update-macaron-sh-script
branch
from
8fa9ee4 to
c2b83a5
Compare
nicallen
reviewed
Jun 26, 2024
tromai
commented
Jun 26, 2024
nicallen
reviewed
Jun 28, 2024
added 9 commits
July 3, 2024 14:05
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
…atus code of run_macaron.sh follows that of docker run Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
…s been set already Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
tromai
force-pushed
the
tromai/update-macaron-sh-script
branch
from
3f3318c to
ee0d533
Compare
|
Rebased to update the changes from #783 |
nicallen
approved these changes
Jul 3, 2024
behnazh-w
approved these changes
Jul 3, 2024
8 tasks
art1f1c3R
pushed a commit
that referenced
this pull request
Nov 29, 2024
Signed-off-by: Trong Nhan Mai <trong.nhan.mai@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request improves token file operations in
run_macaron.sh.run_macaron.shso that if the script exits early, the token file is not persisted within the file system - f88f00adocker runif returns a non-zero status code doesn't trigger early exit (enable byset -e). This enables us to perform the cleaning up before exitingrun_macaron.sh. Furthermore, the return status code ofrun_macaron.shfollows that ofdocker run- af4173e