Skip to content

Conversation

behnazh-w
Copy link
Member

We have made Python 3.11 a requirement for our development environment and use python to run. This PR replaces python3 with python in develoment scripts to be consistent.

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w behnazh-w requested a review from tromai as a code owner June 28, 2024 02:09
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jun 28, 2024
@tromai
Copy link
Contributor

tromai commented Jul 2, 2024

Hmmm I wonder if it's better to change everything to python3 instead 🤔. Not that python in this case is wrong, because we have indicated that we should run everything inside the dev environment created with Python 3.11.
I think python3 is still correct and would be more specific than python. When the reader/developer look through the snippet with python3 in isolation, it would be more clear in my opinion. Otherwise, everything looks good to me.

rm -rf "$VIRTUAL_ENV_PATH"

python3 ./tests/integration/run.py run \
python ./tests/integration/run.py run \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would need to change the same for integration_tests.sh too.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how I missed that :-)
See commit ba87342

Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
@behnazh-w
Copy link
Member Author

Hmmm I wonder if it's better to change everything to python3 instead 🤔. Not that python in this case is wrong, because we have indicated that we should run everything inside the dev environment created with Python 3.11. I think python3 is still correct and would be more specific than python. When the reader/developer look through the snippet with python3 in isolation, it would be more clear in my opinion. Otherwise, everything looks good to me.

No, I don't think it's necessary anymore to use Python 3. Python 2.7 might be still supported in some places but it's rare and since we make it clear we use Python 3, it's fine to avoid repeating python3 everywhere.

Copy link
Contributor

@tromai tromai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@behnazh-w behnazh-w merged commit a06ed41 into staging Jul 3, 2024
@behnazh-w behnazh-w deleted the behnazh/make-py-usages-consistent branch July 30, 2024 05:34
art1f1c3R pushed a commit that referenced this pull request Nov 29, 2024
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants