-
Notifications
You must be signed in to change notification settings - Fork 29
test: use python instead of python3 #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
Hmmm I wonder if it's better to change everything to |
rm -rf "$VIRTUAL_ENV_PATH" | ||
|
||
python3 ./tests/integration/run.py run \ | ||
python ./tests/integration/run.py run \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we would need to change the same for integration_tests.sh
too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how I missed that :-)
See commit ba87342
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
No, I don't think it's necessary anymore to use Python 3. Python 2.7 might be still supported in some places but it's rare and since we make it clear we use Python 3, it's fine to avoid repeating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Signed-off-by: behnazh-w <behnaz.hassanshahi@oracle.com>
We have made
Python 3.11
a requirement for our development environment and usepython
to run. This PR replacespython3
withpython
in develoment scripts to be consistent.