Skip to content

Missing roles (SYSDG) #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
PeterP55P opened this issue Feb 24, 2025 · 14 comments · Fixed by #183
Closed

Missing roles (SYSDG) #180

PeterP55P opened this issue Feb 24, 2025 · 14 comments · Fixed by #183
Assignees

Comments

@PeterP55P
Copy link

Hi I can see that only SYSDBA and SYSOPER roles are supported at the moment. We need other roles to be supported as well. At the moment we are struggling with missing SYSDG role as we need to monitor Standby database that is in MOUNT state.
I can see it as simple adjustment and I would really appreciate if you can add it as soon as possible.
Thank you in advance.

Peter

@markxnelson
Copy link
Member

Hi @PeterP55P thanks for your suggestion, we will take a look and get back to you soon.

@markxnelson markxnelson self-assigned this Feb 25, 2025
@markxnelson
Copy link
Member

todo - add other suth modes as per https://odpi-c.readthedocs.io/en/latest/enums/dpiAuthMode.html#dpiauthmode

@markxnelson
Copy link
Member

looks like this may potentially require a change in godror too - see https://github.com/godror/godror/blob/main/dsn/dsn.go#L163

@PeterP55P
Copy link
Author

Hi @markxnelson thanks for quick answer. I was a bit worried that this change will require changes also in other projects. I have opened a feature request godror/godror#360 to implement SYSDG. I hope someone pick it up so fast as you did.
Thanks,
Peter

@markxnelson
Copy link
Member

Hi @PeterP55P - godror have implemented the needed code - see this commit:

godror/godror@67aeda6

We will pick this up - if you are ok to build from main and test it, that'd be great. We are working on one other issue that I want to fix before we do a new release #177 - hoping to get that fixed in the next day or three as well.

@PeterP55P
Copy link
Author

Yep I saw that. I'm glad that they also act so quickly.

I'll be at my computer earliest on Monday so if you'll release new version by then that would be great. If not I'll try to compile it on my own.
Thank you.

@markxnelson
Copy link
Member

Ok, they have not done a release yet. I see in their changlog, they added this to 0.47.0. I can point to the commit, which would be ok for testing, but for a release, I'd prefer to point at one of their releases, not just a 'random' commit. I'll reach out to them to ask when they plan to release.

@PeterP55P
Copy link
Author

That sounds good. Thanks

@markxnelson
Copy link
Member

FYI, pushed commits in branch 180 which should provide what you need.

@PeterP55P
Copy link
Author

Thanks

@markxnelson
Copy link
Member

fyi changes are in main now

@markxnelson markxnelson reopened this Feb 26, 2025
@markxnelson
Copy link
Member

Fixed in 1.5.4 - please let us know when you have a chance to test if it meets your needs. Thanks very much for your input.

@PeterP55P
Copy link
Author

We did a test and it works perfectly. Thank you @markxnelson

@markxnelson
Copy link
Member

Great, thanks for letting us know. Please don't hesitate to open an issue if you have any other problems or suggestions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants