Add extra admin roles #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
andytael
previously approved these changes
Feb 26, 2025
| if strings.ToUpper(e.config.DbRole) == "SYSOPER" { | ||
| P.IsSysOper = true | ||
| switch strings.ToUpper(e.config.DbRole) { | ||
| case "SYSDBA": |
There was a problem hiding this comment.
This is purely a style recommendation:
- Create a new type for this rather than using string literals
- switch on the new type
There was a problem hiding this comment.
I'd also segregate database role handling code to it's own function/file. gonna suggest database_role.go
There was a problem hiding this comment.
updated to use the AdminRole type from godror, which handles parsing the string, deals with unknown values correctly, etc.
Signed-off-by: Mark Nelson <mark.x.nelson@oracle.com>
anders-swanson
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow the use to connect with additional admin roles.
Note that this uses a commit hash in godror, I plan to update this to a release when they do a release with the necessary change in it, and before we do a release with this commit.
Fixes #180