Check job condition to determine if job has failed in addition to checking job status #2201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to checking status.
alai8
reviewed
Feb 17, 2021
Member
alai8
left a comment
alai8
left a comment
There was a problem hiding this comment.
looks good. Don't forget to add test case to JobWatcherTest.
Member
Author
alai8
approved these changes
Feb 18, 2021
rjeberhard
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR evaluates the job condition in addition to job status to determine if the job has failed. In "etcd restore" test, when job remains in the Pending state for more than
ActiveDeadlineSeconds, the job condition is changed to "failed" but the job status remains null. This causes the fiber to get stuck in theWaitForJobReadystep.