Fix broken links #481
Merged
Fix broken links #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calintje
requested review from
yugure-orca,
philcchen,
rawfalafel,
wjthieme and
odcheung
as code owners
wjthieme
reviewed
Nov 7, 2024
| @@ -197,7 +197,7 @@ async function createMintInstructions( | |||
|
|
|||
| // ConfidentialTransfer | |||
| // [March 6, 2024] getTypeLen(ExtensionType.ConfidentialTransferMint) return 97, but 65 (2 pubkey + 1 bool) is valid | |||
| // https://github.com/solana-labs/solana-program-library/blob/d72289c79a04411c69a8bf1054f7156b6196f9b3/token/js/src/extensions/extensionType.ts#L74 | |||
There was a problem hiding this comment.
This has since been fixed: https://github.com/solana-labs/solana-program-library/blob/55f3d4d67a3be014e0093a7be81bfdaf3b978b00/token/js/src/extensions/extensionType.ts#L81 so we can use the spl-token sdk to get the correct size. Can you create a ticket?
| @@ -413,7 +413,7 @@ describe("open_position_with_metadata", () => { | |||
| await assert.rejects( | |||
| tx.addSigner(defaultMint).buildAndExecute(), | |||
| // InvalidProgramId | |||
| // https://github.com/project-serum/anchor/blob/master/lang/src/error.rs#L180 | |||
| // https://github.com/coral-xyz/anchor/blob/eee03bc7c31ddc99bf3dbe1630283d9226aa7b9c/lang/src/error.rs#L231 | |||
There was a problem hiding this comment.
Maybe use the tag (of the anchor version we use) instead of the commit sha?
legacy-sdk/scripts/whirlpoolNft.json
Outdated
| @@ -9,3 +9,4 @@ | |||
| "family": "Orca Whirlpool Position" | |||
| } | |||
| } | |||
| ?? | |||
| @@ -32,7 +32,7 @@ pub struct OpenPositionWithMetadata<'info> { | |||
| pub position_mint: Account<'info, Mint>, | |||
|
|
|||
| /// CHECK: checked via the Metadata CPI call | |||
| /// https://github.com/metaplex-foundation/metaplex-program-library/blob/master/token-metadata/program/src/utils.rs#L873 | |||
| /// https://github.com/metaplex-foundation/mpl-token-metadata/blob/2f93406c62e791ee93435644c1a3507e910a116b/programs/token-metadata/program/src/utils/metadata.rs#L78C5-L78C39 | |||
There was a problem hiding this comment.
Maybe leave this one referring to master (since they can update their program whenever they want)
wjthieme
reviewed
Nov 7, 2024
| @@ -393,7 +393,7 @@ describe("open_position_with_metadata", () => { | |||
| .addSigner(defaultMint) | |||
| .buildAndExecute(), | |||
| // Invalid Metadata Key | |||
| // https://github.com/metaplex-foundation/metaplex-program-library/blob/master/token-metadata/program/src/error.rs#L36 | |||
| // https://github.com/metaplex-foundation/mpl-token-metadata/blob/2f93406c62e791ee93435644c1a3507e910a116b/programs/token-metadata/program/src/error.rs#L32 | |||
There was a problem hiding this comment.
This would also be master since metaplex can update whenever they want
wjthieme
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix broken links
Details