Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #481

Merged
merged 6 commits into from
Nov 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ Splash Pools are the easiest way to get started:
Concentrated Liquidity Pools offer more flexibility:

1. **Token Mint Addresses**: Provide the two token mints.
2. **Tick Spacing**: Set the tick spacing, which defines the intervals for price ticks. Visit [this link](https://orca-so.gitbook.io/orca-developer-portal/whirlpools/interacting-with-the-protocol/orca-whirlpools-parameters#initialized-feetier-and-tickspacing) to learn more about the available values of tick spacing and their corresponding fee rates.
2. **Tick Spacing**: Set the tick spacing, which defines the intervals for price ticks. Visit the [Whirlpools Parameters](../../../02-Architecture%20Overview/06-Whirlpool%20Parameters.mdx) page to learn more about the available values of tick spacing and their corresponding fee rates.
3. **Initial Price**: Specify the initial price of token 1 in terms of token 2.
4. **Funder**: This can be your wallet, which will fund the pool initialization. If the funder is not specified, the default wallet will be used. You can configure the default wallet through the SDK.
5. **Create instructions**: Use the appropriate function to create the pool.
Expand Down
2 changes: 1 addition & 1 deletion legacy-sdk/scripts/genExpBitConstants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ Decimal.set({ precision: 40, rounding: 4 });
* in Whirlpools.
*
* Explanation on what magic numbers are:
* https://www.notion.so/orcaso/Fixed-Point-Arithmetic-in-Whirlpools-63f9817a852b4029a6eb15dc755c7baf#5df2cfe5d62b4b0aa7e58f5f381c2d55
* https://orcaso.notion.site/External-Tick-Math-Documentation-0dd30688f6a74478a42ffe18968262a9
*/

const x64 = new Decimal(2).pow(64);
Expand Down
2 changes: 1 addition & 1 deletion legacy-sdk/scripts/whirlpoolNft.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@
"name": "Orca Whirlpool Position",
"family": "Orca Whirlpool Position"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class WhirlpoolAccountFetcher

async getAccountRentExempt(refresh: boolean = false): Promise<number> {
// This value should be relatively static or at least not break according to spec
// https://docs.solana.com/developing/programming-model/accounts#rent-exemption
// https://solana.com/docs/terminology#rent-exempt
if (!this._accountRentExempt || refresh) {
this._accountRentExempt =
await this.connection.getMinimumBalanceForRentExemption(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ describe("open_position_with_metadata", () => {
.addSigner(defaultMint)
.buildAndExecute(),
// Invalid Metadata Key
// https://github.com/metaplex-foundation/metaplex-program-library/blob/master/token-metadata/program/src/error.rs#L36
// https://github.com/metaplex-foundation/mpl-token-metadata/blob/main/programs/token-metadata/program/src/error.rs#L34-L36
/0x5/,
);
});
Expand All @@ -413,7 +413,7 @@ describe("open_position_with_metadata", () => {
await assert.rejects(
tx.addSigner(defaultMint).buildAndExecute(),
// InvalidProgramId
// https://github.com/project-serum/anchor/blob/master/lang/src/error.rs#L180
// https://github.com/coral-xyz/anchor/blob/v0.29.0/lang/src/error.rs#L178-L180
/0xbc0/,
);
});
Expand All @@ -432,7 +432,7 @@ describe("open_position_with_metadata", () => {
await assert.rejects(
tx.addSigner(defaultMint).buildAndExecute(),
// InvalidProgramId
// https://github.com/project-serum/anchor/blob/master/lang/src/error.rs#L180
// https://github.com/coral-xyz/anchor/blob/v0.29.0/lang/src/error.rs#L178-L180
/0xbc0/,
);
});
Expand All @@ -451,8 +451,8 @@ describe("open_position_with_metadata", () => {

await assert.rejects(
tx.addSigner(defaultMint).buildAndExecute(),
// AddressConstraint
// https://github.com/project-serum/anchor/blob/master/lang/src/error.rs#L84
// ConstraintAddress
// https://github.com/coral-xyz/anchor/blob/v0.29.0/lang/src/error.rs#L89-L91
/0x7dc/,
);
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ pub struct OpenPositionWithMetadata<'info> {
pub position_mint: Account<'info, Mint>,

/// CHECK: checked via the Metadata CPI call
/// https://github.com/metaplex-foundation/metaplex-program-library/blob/master/token-metadata/program/src/utils.rs#L873
/// https://github.com/metaplex-foundation/mpl-token-metadata/blob/master/programs/token-metadata/program/src/utils/metadata.rs#L78
#[account(mut)]
pub position_metadata_account: UncheckedAccount<'info>,

Expand Down