Implement burn #3437

onchainguy-btc · 2024-04-01T22:00:15Z

After my first burn PR (#2766) got a bit outdated, I created a new one. Tried to make as less changes as possible. This PR does not support burn messages yet. Hope we can get the general burning merged first and then I'm happy to add support for an optional burn message via data pushes.

raphjaph

Finally having a look at this. There's just two things but they probably require a bit of refactoring. Especially the new command ord wallet burn I think is important because burning is quite drastic and we want it to be a very distinct action.

src/subcommand/wallet/send.rs

src/wallet/transaction_builder.rs

onchainguy-btc · 2024-05-07T08:30:55Z

@raphjaph thanks for the feedback, will get that done asap!

onchainguy-btc · 2024-05-07T17:37:54Z

@raphjaph just implemented the changes. Let me know if I can improve on anything else. Can also write some more tests if you have ideas for some good ones.

raphjaph

In OP_RETURNs there is no dust_limit and I see that you correctly disable the check for that. One thing you could try doing is only burn the exact sat that the inscription is on instead of the whole UTXO. This will require some careful changes to the TransactionBuilder, which should then be tested as well in the unit tests of the transaction_builder.rs file.

src/subcommand/wallet/burn.rs

src/subcommand/wallet/send.rs

onchainguy-btc · 2024-05-08T14:09:11Z

In OP_RETURNs there is no dust_limit and I see that you correctly disable the check for that. One thing you could try doing is only burn the exact sat that the inscription is on instead of the whole UTXO. This will require some careful changes to the TransactionBuilder, which should then be tested as well in the unit tests of the transaction_builder.rs file.

@raphjaph Do you think that's worth it? If I'm not mistaking doing so would add additional inputs to the transaction for extracting the sat. The fee for that could potentially be higher than what the inscription sats are worth.

As an alternative idea: What if we exit the ord wallet burn command with an error if the inscription is on a utxo with more than 10_000 sats. This way we can prevent burning large bitcoin amounts by mistake. If people still want to burn the inscriptions, they can first transfer it to a different, smaller output.

crates/ordinals/src/charm.rs

raphjaph · 2024-05-20T23:13:55Z

@raphjaph Do you think that's worth it? If I'm not mistaking doing so would add additional inputs to the transaction for extracting the sat. The fee for that could potentially be higher than what the inscription sats are worth.

That's true, then let's just leave it how it is for now.

As an alternative idea: What if we exit the ord wallet burn command with an error if the inscription is on a utxo with more than 10_000 sats. This way we can prevent burning large bitcoin amounts by mistake. If people still want to burn the inscriptions, they can first transfer it to a different, smaller output.

Sounds reasonble

onchainguy-btc · 2024-05-23T11:22:56Z

@raphjaph Do you think that's worth it? If I'm not mistaking doing so would add additional inputs to the transaction for extracting the sat. The fee for that could potentially be higher than what the inscription sats are worth.

That's true, then let's just leave it how it is for now.

As an alternative idea: What if we exit the ord wallet burn command with an error if the inscription is on a utxo with more than 10_000 sats. This way we can prevent burning large bitcoin amounts by mistake. If people still want to burn the inscriptions, they can first transfer it to a different, smaller output.

Sounds reasonble

Cool, will adapt to that!

raphjaph · 2024-06-02T20:05:20Z

Let me know when this is ready for review :)

onchainguy-btc · 2024-06-03T18:26:22Z

@raphjaph Ready for review ✅

onchainguy-btc · 2024-06-28T13:21:05Z

@raphjaph just saw you merged master? Was that on purpose? I can also just rebase if you like.

raphjaph · 2024-06-28T16:03:13Z

@onchainguy-btc don't worry about rebasing, I'm going to squash merge this anyway. Gonna have a look at this today or tomorrow.

The tests and linting also don't seem to pass yet. If you could fix, that would be great :)

You can run our CI if you install just and run just ci.

raphjaph

See comments above

Co-authored-by: raph <raphjaph@protonmail.com>

onchainguy-btc · 2024-09-06T08:16:51Z

@raphjaph just implemented the tests you requested ✅

raphjaph

Awesome, LGTM!

reviewed

* Change test-bitcoincore-rpc to mockcore in README.md (ordinals#3842) * Commit twice to work around redb off-by-one bug (ordinals#3856) * Release 0.19.1 (ordinals#3864) - Bump version: 0.19.0 → 0.19.1 - Update changelog - Update changelog contributor credits - Update dependencies * Update Portuguese Translation pt.po (ordinals#3837) * Updated Chinese translation (ordinals#3881) * Fix rune links for runes with no symbol (ordinals#3849) * Suppress printing sat_ranges by default (ordinals#3867) * Re-enter beta (ordinals#3884) * Update pointer specification (ordinals#3861) * Clarify that unused runes tags should not be used (ordinals#3885) * Migrate object.rs to snafu error handling (ordinals#3858) * Make index settings harder to misuse (ordinals#3893) * Don't unnecessarily insert into utxo cache when indexing addresses (ordinals#3894) * Remove trailing space from runes specification (ordinals#3896) * Serve responses with cross origin isolation headers (ordinals#3898) * List all Bitcoin Core wallets (ordinals#3902) * Make first first and last sat in range clickable (ordinals#3903) * Migrate Outgoing to SnafuError (ordinals#3854) * Update Bitcoin Core deploy to 27.1 (ordinals#3912) * Add sat_balance to address API (ordinals#3905) Co-authored-by: raph <raphjaph@protonmail.com> * Add Dutch translation to Ordinals Handbook (ordinals#3907) * Migrate chain.rs to snafu error (ordinals#3904) * Bump version to 0.20.0-dev (ordinals#3916) * Revert "Serve responses with cross origin isolation headers" (ordinals#3920) * Remove inscription content type counts from /status page (ordinals#3922) * Unified OUTPOINT_TO_UTXO_ENTRY table (ordinals#3915) - Upgrade `redb` to 2.1.1 - Remove `--index-spent-sats` - Remove redundant pointer handling in `index_inscriptions()` - Fix incorrect `is_output_spent()` results when not using `--index-sats` - Unify UTXO index data in `OUTPOINT_TO_UTXO_ENTRY` table - Read addresses from index when exporting * Add address field to `/r/inscription/:id` (ordinals#3891) * Add inscriptions and runes details to address API endpoint (ordinals#3924) * Release 0.20.0 (ordinals#3928) - Bump ord version: 0.19.1 → 0.20.0 - Bump ordinals version: 0.0.9 → 0.0.10 - Update changelog - Update changelog contributor credits - Update dependencies * Bump version to 0.20.0-dev (ordinals#3929) * Add test to remind us to fix the UtxoEntry redb type name (ordinals#3934) * Put AddressInfo into api module (ordinals#3933) * Fix clippy lint (ordinals#3937) * Add inscription index to /status (ordinals#3938) * Remove unnecessary symbols in docs/src/guides/testing.md (ordinals#3945) * Add inscription examples to handbook (ordinals#3769) * Allow scrolling in iframe (ordinals#3947) * Skip serializing None in batch::File (ordinals#3943) * Fix /output page (ordinals#3948) * Add `/satpoint/<SATPOINT>` endpoint (ordinals#3949) * Don't log RPC connections to bitcoind (ordinals#3952) * Start indexing at correct block height (ordinals#3956) * Fix output API struct (ordinals#3957) * Remove dependency on `ord-bitcoincore-rpc` crate (ordinals#3959) * Keep sat ranges in low-level format (ordinals#3963) * Implement burn for wallet command (ordinals#3437) * Add multi parent support to wallet (ordinals#3228) * Get parents using `as_slice` instead of converting to `Vec` (ordinals#3972) * Rename parents_values -> parent_values (ordinals#3973) * Fix non-existant output lookup (ordinals#3968) * Release 0.20.1 (ordinals#3975) * Refactor burn command (ordinals#3976) * Remove regtest.ordinals.net just recipes (ordinals#3978) * Add `ord verify` (ordinals#3906) * Release 0.21.0 (ordinals#3997) - Bump version: 0.20.1 → 0.21.0 - Update changelog - Update changelog contributor credits - Update dependencies * Remove /runes/balances API endpoint (ordinals#3980) * Update rust-bitcoin in ord (ordinals#3962) * Revert redb to 2.1.3 (ordinals#4003) * Release 0.21.1 (ordinals#4006) * Update Bitcoin Core install script (ordinals#4007) * Remove pre-alpha warning from ord help (ordinals#4011) * Change mint progress to `mints / terms.cap` (ordinals#4012) * Only show rune mint progress during mint (ordinals#4013) * Show if JSON API is enabled on /status (ordinals#4014) * Fix build error --------- Co-authored-by: Anchor <49644098+TheHeBoy@users.noreply.github.com> Co-authored-by: Casey Rodarmor <casey@rodarmor.com> Co-authored-by: 0xArtur <metaverseartur@gmail.com> Co-authored-by: Dr.JingLee <95461562+DrJingLee@users.noreply.github.com> Co-authored-by: nine <118634361+cryptoni9n@users.noreply.github.com> Co-authored-by: Bohdan Cryptolions <37701692+ansigroup@users.noreply.github.com> Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: Patrick Collins <patrick@collinatorstudios.com> Co-authored-by: Tibebtc <tibedekock@live.nl> Co-authored-by: partialord <178683722+partialord@users.noreply.github.com> Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com> Co-authored-by: twosatsmaxi <vashalpesh@gmail.com> Co-authored-by: tiaoxizhan <tiaoxizhan@outlook.com> Co-authored-by: onchainguy <1436535+onchainguy-btc@users.noreply.github.com> Co-authored-by: lifofifo <134870335+lifofifoX@users.noreply.github.com> Co-authored-by: dcorral <hi@dcorral.com>

* Change test-bitcoincore-rpc to mockcore in README.md (ordinals#3842) * Commit twice to work around redb off-by-one bug (ordinals#3856) * Release 0.19.1 (ordinals#3864) - Bump version: 0.19.0 → 0.19.1 - Update changelog - Update changelog contributor credits - Update dependencies * Update Portuguese Translation pt.po (ordinals#3837) * Updated Chinese translation (ordinals#3881) * Fix rune links for runes with no symbol (ordinals#3849) * Suppress printing sat_ranges by default (ordinals#3867) * Re-enter beta (ordinals#3884) * Update pointer specification (ordinals#3861) * Clarify that unused runes tags should not be used (ordinals#3885) * Migrate object.rs to snafu error handling (ordinals#3858) * Make index settings harder to misuse (ordinals#3893) * Don't unnecessarily insert into utxo cache when indexing addresses (ordinals#3894) * Remove trailing space from runes specification (ordinals#3896) * Serve responses with cross origin isolation headers (ordinals#3898) * List all Bitcoin Core wallets (ordinals#3902) * Make first first and last sat in range clickable (ordinals#3903) * Migrate Outgoing to SnafuError (ordinals#3854) * Update Bitcoin Core deploy to 27.1 (ordinals#3912) * Add sat_balance to address API (ordinals#3905) Co-authored-by: raph <raphjaph@protonmail.com> * Add Dutch translation to Ordinals Handbook (ordinals#3907) * Migrate chain.rs to snafu error (ordinals#3904) * Bump version to 0.20.0-dev (ordinals#3916) * Revert "Serve responses with cross origin isolation headers" (ordinals#3920) * Remove inscription content type counts from /status page (ordinals#3922) * Unified OUTPOINT_TO_UTXO_ENTRY table (ordinals#3915) - Upgrade `redb` to 2.1.1 - Remove `--index-spent-sats` - Remove redundant pointer handling in `index_inscriptions()` - Fix incorrect `is_output_spent()` results when not using `--index-sats` - Unify UTXO index data in `OUTPOINT_TO_UTXO_ENTRY` table - Read addresses from index when exporting * Add address field to `/r/inscription/:id` (ordinals#3891) * Add inscriptions and runes details to address API endpoint (ordinals#3924) * Release 0.20.0 (ordinals#3928) - Bump ord version: 0.19.1 → 0.20.0 - Bump ordinals version: 0.0.9 → 0.0.10 - Update changelog - Update changelog contributor credits - Update dependencies * Bump version to 0.20.0-dev (ordinals#3929) * Add test to remind us to fix the UtxoEntry redb type name (ordinals#3934) * Put AddressInfo into api module (ordinals#3933) * Fix clippy lint (ordinals#3937) * Add inscription index to /status (ordinals#3938) * Remove unnecessary symbols in docs/src/guides/testing.md (ordinals#3945) * Add inscription examples to handbook (ordinals#3769) * Allow scrolling in iframe (ordinals#3947) * Skip serializing None in batch::File (ordinals#3943) * Fix /output page (ordinals#3948) * Add `/satpoint/<SATPOINT>` endpoint (ordinals#3949) * Don't log RPC connections to bitcoind (ordinals#3952) * Start indexing at correct block height (ordinals#3956) * Fix output API struct (ordinals#3957) * Remove dependency on `ord-bitcoincore-rpc` crate (ordinals#3959) * Keep sat ranges in low-level format (ordinals#3963) * Implement burn for wallet command (ordinals#3437) * Add multi parent support to wallet (ordinals#3228) * Get parents using `as_slice` instead of converting to `Vec` (ordinals#3972) * Rename parents_values -> parent_values (ordinals#3973) * Fix non-existant output lookup (ordinals#3968) * Release 0.20.1 (ordinals#3975) * Refactor burn command (ordinals#3976) * Remove regtest.ordinals.net just recipes (ordinals#3978) * Add `ord verify` (ordinals#3906) * Release 0.21.0 (ordinals#3997) - Bump version: 0.20.1 → 0.21.0 - Update changelog - Update changelog contributor credits - Update dependencies * Remove /runes/balances API endpoint (ordinals#3980) * Update rust-bitcoin in ord (ordinals#3962) * Revert redb to 2.1.3 (ordinals#4003) * Release 0.21.1 (ordinals#4006) * Update Bitcoin Core install script (ordinals#4007) * Remove pre-alpha warning from ord help (ordinals#4011) * Change mint progress to `mints / terms.cap` (ordinals#4012) * Only show rune mint progress during mint (ordinals#4013) * Show if JSON API is enabled on /status (ordinals#4014) * Update JSON-API & Recursive documentation (ordinals#3984) * Document POST method for /inscriptions (ordinals#4017) * Add authors to Handbook (ordinals#4018) * Add more info to `wallet outputs` (ordinals#4019) * Add `wallet addresses` (ordinals#4005) * Add BIP322 `wallet sign` (ordinals#3988) * Add `/r/undelegated-content/<INSCRIPTION_ID>` (ordinals#3932) * Show total child count (ordinals#4009) * Create change output when inputs containing non-outgoing runes are selected (ordinals#4028) * Release 0.21.2 (ordinals#4029) - Bump version: 0.21.1 → 0.21.2 - Update changelog - Update changelog contributor credits * Allow fallback for satpoints and addresses (ordinals#4033) * Un-pin redb dependency and update to 2.2.0 (ordinals#4032) * Add `ord wallet split` command for splitting utxos (ordinals#4030) * Hide image preview and thumbnail scrollbars (ordinals#4042) * Rescan wallet on restore (ordinals#4041) * Do not chunk runestone data pushes (ordinals#4036) * Add simple taproot HD wallet to mockcore (ordinals#4038) * Collapse long strings in HTML (ordinals#4053) * BIP322 sign file (ordinals#4026) * Identify collapsible nodes with class=collapse (ordinals#4055) * Add assert_html function (ordinals#4058) * Allow including metadata when burning inscriptions (ordinals#4045) * Get output information by address (ordinals#4056) * Document split command (ordinals#4062) * Add palindrome charm (ordinals#4064) * Allow restoring wallet with custom timestamp (ordinals#4065) * Release 0.21.3 (ordinals#4059) - Bump version: 0.21.2 → 0.21.3 - Update changelog - Update changelog contributor credits - Update dependencies - Pin `bitcoin` to 0.32.3 - Downgrade `bip322` to 0.0.8 * Add Cargo.lock --------- Co-authored-by: Anchor <49644098+TheHeBoy@users.noreply.github.com> Co-authored-by: Casey Rodarmor <casey@rodarmor.com> Co-authored-by: 0xArtur <metaverseartur@gmail.com> Co-authored-by: Dr.JingLee <95461562+DrJingLee@users.noreply.github.com> Co-authored-by: nine <118634361+cryptoni9n@users.noreply.github.com> Co-authored-by: Bohdan Cryptolions <37701692+ansigroup@users.noreply.github.com> Co-authored-by: raph <raphjaph@protonmail.com> Co-authored-by: Patrick Collins <patrick@collinatorstudios.com> Co-authored-by: Tibebtc <tibedekock@live.nl> Co-authored-by: partialord <178683722+partialord@users.noreply.github.com> Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com> Co-authored-by: twosatsmaxi <vashalpesh@gmail.com> Co-authored-by: tiaoxizhan <tiaoxizhan@outlook.com> Co-authored-by: onchainguy <1436535+onchainguy-btc@users.noreply.github.com> Co-authored-by: lifofifo <134870335+lifofifoX@users.noreply.github.com> Co-authored-by: Arik <arik-so@users.noreply.github.com>

This was referenced Apr 3, 2024

Sacrifices #3025

Open

Burn addresses #1588

Open

onchainguy-btc force-pushed the implement-burn-2 branch 7 times, most recently from 58c008e to 61fcd70 Compare April 14, 2024 20:06

onchainguy-btc mentioned this pull request Apr 14, 2024

Allow burning inscriptions #1333

Open

onchainguy-btc mentioned this pull request Apr 29, 2024

feat: burn rune through forcing Cenotaph #3683

Closed

onchainguy-btc force-pushed the implement-burn-2 branch from 61fcd70 to 7d4947e Compare May 6, 2024 12:56

onchainguy-btc mentioned this pull request May 6, 2024

Refactoring send.rs by introducing transfer trait #3728

Closed

raphjaph requested changes May 6, 2024

View reviewed changes

src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved

src/wallet/transaction_builder.rs Outdated Show resolved Hide resolved

raphjaph added the enhancement label May 6, 2024

raphjaph requested changes May 8, 2024

View reviewed changes

src/subcommand/wallet/burn.rs Outdated Show resolved Hide resolved

src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved

src/subcommand/wallet/send.rs Outdated Show resolved Hide resolved

raphjaph requested changes May 20, 2024

View reviewed changes

crates/ordinals/src/charm.rs Outdated Show resolved Hide resolved

onchainguy-btc force-pushed the implement-burn-2 branch from ebf9b98 to 9666a4f Compare May 31, 2024 20:18

onchainguy-btc requested a review from raphjaph June 10, 2024 14:33

yubing744 mentioned this pull request Jun 27, 2024

[Bitcoin] Inscription burn rooch-network/rooch#2012

Closed

raphjaph requested changes Jun 28, 2024

View reviewed changes

onchainguy-btc and others added 15 commits September 6, 2024 10:15

Some cleanups

edb1a9b

Refactor according to feedback

e86a5d0

Revert spaces

c008f24

Ran just

f8eec52

Update src/subcommand/wallet/burn.rs

95f624b

Co-authored-by: raph <raphjaph@protonmail.com>

Update src/subcommand/wallet.rs

153a2d5

Co-authored-by: raph <raphjaph@protonmail.com>

Update src/subcommand/wallet/burn.rs

5b5c6c6

Co-authored-by: raph <raphjaph@protonmail.com>

Update src/wallet/transaction_builder.rs

70ca043

Co-authored-by: raph <raphjaph@protonmail.com>

Fix build

f969bd2

Cleanup

0f8fe0b

Protect postage

fbcfad7

Move signing function to wallet struct

0fc2bf6

Only parse inscription ids from command line

ac7e99e

Run the fuzzing tests

eaf105e

More tests

14e4472

onchainguy-btc force-pushed the implement-burn-2 branch from 6c0ce1c to 14e4472 Compare September 6, 2024 08:16

onchainguy-btc requested a review from raphjaph September 6, 2024 18:20

raphjaph and others added 5 commits September 8, 2024 12:09

Merge branch 'master' into implement-burn-2

3401133

Merge branch 'master' into implement-burn-2

f842678

Fix test

5d36ec6

Merge branch 'master' into implement-burn-2

65fbe40

Merge branch 'master' of github.com:ordinals/ord into implement-burn-2

54ba537

raphjaph approved these changes Sep 30, 2024

View reviewed changes

raphjaph enabled auto-merge (squash) September 30, 2024 14:17

raphjaph merged commit 9bc83eb into ordinals:master Sep 30, 2024
5 checks passed

BrewTestBot mentioned this pull request Oct 3, 2024

ord 0.20.1 Homebrew/homebrew-core#192779

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement burn #3437

Implement burn #3437

onchainguy-btc commented Apr 1, 2024

raphjaph left a comment

onchainguy-btc commented May 7, 2024

onchainguy-btc commented May 7, 2024

raphjaph left a comment

onchainguy-btc commented May 8, 2024

raphjaph commented May 20, 2024

onchainguy-btc commented May 23, 2024

raphjaph commented Jun 2, 2024

onchainguy-btc commented Jun 3, 2024

onchainguy-btc commented Jun 28, 2024

raphjaph commented Jun 28, 2024 •

edited

Loading

raphjaph left a comment

onchainguy-btc commented Sep 6, 2024

raphjaph left a comment

Implement burn #3437

Implement burn #3437

Conversation

onchainguy-btc commented Apr 1, 2024

raphjaph left a comment

Choose a reason for hiding this comment

onchainguy-btc commented May 7, 2024

onchainguy-btc commented May 7, 2024

raphjaph left a comment

Choose a reason for hiding this comment

onchainguy-btc commented May 8, 2024

raphjaph commented May 20, 2024

onchainguy-btc commented May 23, 2024

raphjaph commented Jun 2, 2024

onchainguy-btc commented Jun 3, 2024

onchainguy-btc commented Jun 28, 2024

raphjaph commented Jun 28, 2024 • edited Loading

raphjaph left a comment

Choose a reason for hiding this comment

onchainguy-btc commented Sep 6, 2024

raphjaph left a comment

Choose a reason for hiding this comment

raphjaph commented Jun 28, 2024 •

edited

Loading