Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make first first and last sat in range clickable #3903

Merged
merged 6 commits into from
Aug 17, 2024
Merged

Make first first and last sat in range clickable #3903

merged 6 commits into from
Aug 17, 2024

Conversation

raphjaph
Copy link
Collaborator

@raphjaph raphjaph commented Aug 16, 2024 •
edited
Loading

@raphjaph
Copy link
Collaborator Author

I don't understand why these tests are failing, i hate the html tests.

@raphjaph raphjaph requested a review from casey August 16, 2024 12:42
@casey
Copy link
Collaborator

casey commented Aug 16, 2024

The only additional information that the range page has is the total number of sats in the range. Instead of adding a (range) link, we could instead directly add the value to the ranges:

0–10 (10 sats)

And remove the range page entirely. The range page is one of the most useless pages anyways.

@raphjaph
Copy link
Collaborator Author

I like that, will remove the ranges page in this PR

@raphjaph
Copy link
Collaborator Author

It's done but I can't figure out what's wrong with the html tests. Could you maybe glance at them for 2mins? Maybe it'll jump out to you

@casey
Copy link
Collaborator

casey commented Aug 16, 2024

Is the the parens? (…) is the regex grouping operator, so it doesn't match a literal (…). I would just remove that (range) note anyways.

@raphjaph raphjaph merged commit 19f9198 into ordinals:master Aug 17, 2024
5 checks passed
@cryptoni9n cryptoni9n mentioned this pull request Aug 26, 2024
Closed
@BrewTestBot BrewTestBot mentioned this pull request Sep 3, 2024
Merged
danadi7 pushed a commit to sadoprotocol/ord that referenced this pull request Sep 20, 2024
@dcorral @TheHeBoy
@casey @0xArtur @DrJingLee @cryptoni9n @ansigroup @raphjaph @patrick99e99 @Tibebtc @partialord @elocremarc @twosatsmaxi
chore(ord): update 0.20.0 (#15)
328d052 
* Change test-bitcoincore-rpc to mockcore in README.md (ordinals#3842)

* Commit twice to work around redb off-by-one bug (ordinals#3856)

* Release 0.19.1 (ordinals#3864)

- Bump version: 0.19.0 → 0.19.1
- Update changelog
- Update changelog contributor credits
- Update dependencies

* Update Portuguese Translation pt.po (ordinals#3837)

* Updated Chinese translation  (ordinals#3881)

* Fix rune links for runes with no symbol (ordinals#3849)

* Suppress printing sat_ranges by default (ordinals#3867)

* Re-enter beta (ordinals#3884)

* Update pointer specification (ordinals#3861)

* Clarify that unused runes tags should not be used (ordinals#3885)

* Migrate object.rs to snafu error handling (ordinals#3858)

* Make index settings harder to misuse (ordinals#3893)

* Don't unnecessarily insert into utxo cache when indexing addresses (ordinals#3894)

* Remove trailing space from runes specification (ordinals#3896)

* Serve responses with cross origin isolation headers (ordinals#3898)

* List all Bitcoin Core wallets (ordinals#3902)

* Make first first and last sat in range clickable (ordinals#3903)

* Migrate Outgoing to SnafuError (ordinals#3854)

* Update Bitcoin Core deploy to 27.1 (ordinals#3912)

* Add sat_balance to address API (ordinals#3905)

Co-authored-by: raph <raphjaph@protonmail.com>

* Add Dutch translation to Ordinals Handbook (ordinals#3907)

* Migrate chain.rs to snafu error (ordinals#3904)

* Bump version to 0.20.0-dev (ordinals#3916)

* Revert "Serve responses with cross origin isolation headers" (ordinals#3920)

* Remove inscription content type counts from /status page (ordinals#3922)

* Unified OUTPOINT_TO_UTXO_ENTRY table (ordinals#3915)

- Upgrade `redb` to 2.1.1
- Remove `--index-spent-sats`
- Remove redundant pointer handling in `index_inscriptions()`
- Fix incorrect `is_output_spent()` results when not using `--index-sats`
- Unify UTXO index data in `OUTPOINT_TO_UTXO_ENTRY` table
- Read addresses from index when exporting

* Add address field to `/r/inscription/:id` (ordinals#3891)

* Add inscriptions and runes details to address API endpoint (ordinals#3924)

* Release 0.20.0 (ordinals#3928)

- Bump ord version: 0.19.1 → 0.20.0
- Bump ordinals version: 0.0.9 → 0.0.10
- Update changelog
- Update changelog contributor credits
- Update dependencies

---------

Co-authored-by: Anchor <49644098+TheHeBoy@users.noreply.github.com>
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
Co-authored-by: 0xArtur <metaverseartur@gmail.com>
Co-authored-by: Dr.JingLee <95461562+DrJingLee@users.noreply.github.com>
Co-authored-by: nine <118634361+cryptoni9n@users.noreply.github.com>
Co-authored-by: Bohdan Cryptolions <37701692+ansigroup@users.noreply.github.com>
Co-authored-by: raph <raphjaph@protonmail.com>
Co-authored-by: Patrick Collins <patrick@collinatorstudios.com>
Co-authored-by: Tibebtc <tibedekock@live.nl>
Co-authored-by: partialord <178683722+partialord@users.noreply.github.com>
Co-authored-by: Eloc <42568538+elocremarc@users.noreply.github.com>
Co-authored-by: twosatsmaxi <vashalpesh@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@casey casey casey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphjaph @casey