Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌔 Moon phase #42

Closed
orontee opened this issue Sep 16, 2023 · 0 comments
Closed

🌔 Moon phase #42

orontee opened this issue Sep 16, 2023 · 0 comments
Labels
enhancement New feature or request feature screenshots Issue implies screenshots update
Milestone
Next release

Comments

@orontee
Copy link
Owner

orontee commented Sep 16, 2023 •
edited
Loading

Context

About moon_phase attribute in One Call API responses:

0 and 1 are 'new moon', 0.25 is 'first quarter moon', 0.5 is 'full moon' and 0.75 is 'last quarter moon'. The periods in between are called 'waxing crescent', 'waxing gibous', 'waning gibous', and 'waning crescent', respectively.

https://fr.wikipedia.org/wiki/Phase_de_la_Lune

Proposal

First idea was to provide 4 icons for new, first quarter, full and last quarter moon. What would be a good "new moon" icon??!

Text is better than icons to display moon phase.

Due to lacks of space can't be done in daily forecast box. Delayed to daily forecast dialog: See #16.
@orontee orontee added enhancement New feature or request feature labels Sep 16, 2023
@orontee orontee mentioned this issue Sep 17, 2023
Closed
@orontee orontee added the screenshots Issue implies screenshots update label Sep 17, 2023
orontee added a commit that referenced this issue Sep 17, 2023
@orontee
WIP
9b561e7 
Refs: #42
orontee added a commit that referenced this issue Sep 17, 2023
@orontee
WIP
91d4816 
Refs: #42
@orontee orontee mentioned this issue Sep 18, 2023
Closed
@orontee orontee mentioned this issue Nov 15, 2023
Open
@orontee orontee changed the title Moon phase 🌔 Moon phase Jun 21, 2024
@orontee orontee mentioned this issue Aug 4, 2024
Closed
8 tasks
@orontee orontee closed this as completed Nov 3, 2024
@orontee orontee added this to the Next release milestone Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request feature screenshots Issue implies screenshots update
Projects
None yet
Milestone
Next release
Development

When branches are created from issues, their pull requests are automatically linked.

42-moon-phase orontee/taranis
1 participant
@orontee