Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dialog with conditions details #16

Closed
7 of 8 tasks
orontee opened this issue Aug 29, 2023 · 4 comments
Closed
7 of 8 tasks

Display dialog with conditions details #16

orontee opened this issue Aug 29, 2023 · 4 comments

Comments

@orontee
Copy link
Owner

orontee commented Aug 29, 2023

Context

I sometime wants to read the UV index or compare raw and felt temperatures. It's impossible to display all information on the daily forecast nor the hourly forecast.

Analysis

Display a dialog with condition details. Possible for both daily and hourly forecast.

Just start with daily forecast.

TODO

  • Wind direction
  • Moon phase (See 🌔 Moon phase #42)
  • Dew point
  • Replace temperatures table with a plot (non-sense since no time for min and max and no felt extrema)
  • Weather icon
  • Secondary weather description
  • Draw separators, not empty lines
  • Close button
  • Scrollbar
  • Translations (French is already done)
  • Elide long values (may not be needed...)

Remarks

  • A bug in current deserialization of felt temperatures will explain users seeing wrong values if they start the application with an up-to-date cache.
  • Secondary weather description (the summary property of OpenWeather API response) isn't translated; It's shown iff current language is English.
@orontee orontee added this to the First version milestone Aug 29, 2023
orontee added a commit that referenced this issue Aug 30, 2023
orontee added a commit that referenced this issue Aug 30, 2023
orontee added a commit that referenced this issue Aug 30, 2023
orontee added a commit that referenced this issue Aug 30, 2023
orontee added a commit that referenced this issue Aug 30, 2023
orontee added a commit that referenced this issue Aug 31, 2023
orontee added a commit that referenced this issue Aug 31, 2023
orontee added a commit that referenced this issue Sep 2, 2023
@orontee orontee removed this from the First version milestone Sep 3, 2023
orontee added a commit that referenced this issue Sep 3, 2023
orontee added a commit that referenced this issue Sep 3, 2023
@orontee orontee closed this as completed Oct 1, 2023
@orontee orontee reopened this Aug 4, 2024
orontee added a commit that referenced this issue Aug 4, 2024
@orontee
Copy link
Owner Author

orontee commented Aug 4, 2024

New version, implemented as a modal widget.

Already working, most wanted information is present (wind direction, dew point and moon phase are missing), but still needs some style improvement.

orontee added a commit that referenced this issue Aug 4, 2024
@orontee orontee self-assigned this Aug 4, 2024
@orontee orontee added this to the Next release milestone Aug 4, 2024
@orontee orontee mentioned this issue Aug 4, 2024
orontee added a commit that referenced this issue Nov 2, 2024
orontee added a commit that referenced this issue Nov 2, 2024
orontee added a commit that referenced this issue Nov 2, 2024
orontee added a commit that referenced this issue Nov 2, 2024
@orontee
Copy link
Owner Author

orontee commented Nov 2, 2024

Made some changes:

  • Modal dialogs aren't necessarily full screen anymore
  • Add wind direction

UI improvments to be worked on:

  • Close button
  • Scrollbar

Content missing (can wait):

  • Weather icon
  • Weather secondary description when available
  • Moon phase

orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
orontee added a commit that referenced this issue Nov 3, 2024
@orontee
Copy link
Owner Author

orontee commented Nov 3, 2024

Looks good now. Scrollbar can be done later.

daily_forecast_dialog

@orontee orontee closed this as completed Nov 3, 2024
@orontee
Copy link
Owner Author

orontee commented Nov 3, 2024

Temperatures should be transposed to fill four rows only and wind information should occupy a single line. To limit need for scrolling, improve readability, and be coherent with temperatures in daily forecast box.

@orontee orontee reopened this Nov 3, 2024
orontee added a commit that referenced this issue Nov 13, 2024
orontee added a commit that referenced this issue Nov 13, 2024
orontee added a commit that referenced this issue Nov 13, 2024
@orontee orontee closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant