Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetry support #2597

Closed
driverpt opened this issue Jun 30, 2021 · 8 comments
Closed

OpenTelemetry support #2597

driverpt opened this issue Jun 30, 2021 · 8 comments
Labels
feat New feature or request.

Comments

@driverpt
Copy link

Is your feature request related to a problem? Please describe.

At the moment Hydra does not support NewRelic Tracing, but since most of the providers already support OpenTelemetry Standard, it would be nice to support this Standard.

Describe the solution you'd like

As title says

Describe alternatives you've considered

N/A

Additional context

N/A

@aeneasr
Copy link
Member

aeneasr commented Jun 30, 2021

Yup, the place to add that would be around here: https://github.com/ory/x/blob/master/tracing/tracer.go#L154

Contribs welcomed!

@aeneasr aeneasr added the feat New feature or request. label Jun 30, 2021
@driverpt
Copy link
Author

driverpt commented Jul 3, 2021

I did some digging and this might be a breaking change, which approach you suggest?

@aeneasr
Copy link
Member

aeneasr commented Jul 5, 2021

What would be the breaking change?

@driverpt
Copy link
Author

driverpt commented Jul 5, 2021

Currently there is still no clear migration strategy to Opentelemetry from Opentracing

open-telemetry/opentelemetry-go#453

It's still unclear the way to go with the new Go Lib

@aeneasr
Copy link
Member

aeneasr commented Jul 5, 2021

The original issue was about new relic right? So new relic does not support the way we currently do metrics? If so, a breaking change would only be acceptable if we keep support for all existing providers

@driverpt
Copy link
Author

driverpt commented Jul 5, 2021

Newrelic supports Open Telemetry Spec. But regarding the code itself, the interface has changed and some older providers may not be supported.

@matoous
Copy link
Contributor

matoous commented Dec 16, 2021

👋 heya, I tried to address this issue in ory/x#440. Ones it is merged (if it is merged) I will open PR also here.

@aeneasr
Copy link
Member

aeneasr commented Jan 1, 2022

ory/x is merged :)

aeneasr added a commit that referenced this issue Jan 5, 2022
This fix addresses an issue where configuration values in arrays could not be loaded from environment variables, which is now possible. For more information on how Ory Hydra parses configuration, [head over to the documentation](https://www.ory.sh/docs/ecosystem/configuring/)!

Additionally, this PR resolves a build issue on FreeBSD - making it now possible to compile Ory Hydra with the FreeBSD target.

Lastly, this change adds OpenTelemetry support!

Closes #2597
Closes #2912
@aeneasr aeneasr closed this as completed in 5158faa Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request.
Projects
None yet
Development

No branches or pull requests

3 participants