-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry support #2597
Comments
Yup, the place to add that would be around here: https://github.com/ory/x/blob/master/tracing/tracer.go#L154 Contribs welcomed! |
I did some digging and this might be a breaking change, which approach you suggest? |
What would be the breaking change? |
Currently there is still no clear migration strategy to Opentelemetry from Opentracing open-telemetry/opentelemetry-go#453 It's still unclear the way to go with the new Go Lib |
The original issue was about new relic right? So new relic does not support the way we currently do metrics? If so, a breaking change would only be acceptable if we keep support for all existing providers |
Newrelic supports Open Telemetry Spec. But regarding the code itself, the interface has changed and some older providers may not be supported. |
👋 heya, I tried to address this issue in ory/x#440. Ones it is merged (if it is merged) I will open PR also here. |
ory/x is merged :) |
This fix addresses an issue where configuration values in arrays could not be loaded from environment variables, which is now possible. For more information on how Ory Hydra parses configuration, [head over to the documentation](https://www.ory.sh/docs/ecosystem/configuring/)! Additionally, this PR resolves a build issue on FreeBSD - making it now possible to compile Ory Hydra with the FreeBSD target. Lastly, this change adds OpenTelemetry support! Closes #2597 Closes #2912
Is your feature request related to a problem? Please describe.
At the moment Hydra does not support NewRelic Tracing, but since most of the providers already support OpenTelemetry Standard, it would be nice to support this Standard.
Describe the solution you'd like
As title says
Describe alternatives you've considered
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: