Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): opentelemetry tracing #2923

Merged
merged 1 commit into from
Jan 11, 2022
Merged

feat(docs): opentelemetry tracing #2923

merged 1 commit into from
Jan 11, 2022

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Jan 7, 2022

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

Fixes the issue of otel not being configurable as the value isn't allowed in providers enum. Also adds docs for otel tracing.

@matoous matoous requested a review from aeneasr as a code owner January 7, 2022 11:54
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #2923 (1b6fc10) into master (3236e31) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2923   +/-   ##
=======================================
  Coverage   78.26%   78.26%           
=======================================
  Files         110      110           
  Lines        7731     7731           
=======================================
  Hits         6051     6051           
  Misses       1265     1265           
  Partials      415      415           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3236e31...1b6fc10. Read the comment docs.

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for your contribution! This looks pretty good and I have some ideas how to improve it further :)

quickstart-tracing.yml Show resolved Hide resolved
@aeneasr aeneasr merged commit 74da7b6 into ory:master Jan 11, 2022
@matoous matoous deleted the md/otel-docs branch January 11, 2022 13:35
@vinckr
Copy link
Member

vinckr commented Jan 12, 2022

Hello @matoous
Congrats on merging your first PR in Ory 🎉 !
Your contribution will soon be helping secure millions of identities around the globe 🌏.
As a small token of appreciation we send all our first time contributors a gift package to welcome them to the community.
Please drop me an email to claim your Ory swag!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants