Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update README #3032

Merged
merged 1 commit into from
Mar 10, 2022
Merged

fix: update README #3032

merged 1 commit into from
Mar 10, 2022

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Mar 9, 2022

Updates the README

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security. vulnerability, I
    confirm that I got green light (please contact
    security@ory.sh) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@vinckr vinckr requested a review from aeneasr as a code owner March 9, 2022 15:40
@mitar
Copy link
Contributor

mitar commented Mar 9, 2022

Related: Installation mentions go install -tags sqlite,json1,hsm . Are those tags and why one should use them documented somewhere?

@aeneasr
Copy link
Member

aeneasr commented Mar 10, 2022

They are needed for certain CGO modules we use. You can omit them if you don't need SQLite or HSM

@aeneasr aeneasr merged commit 980c2d8 into ory:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README does not point to developer documentation
3 participants