fix: handle server error when refresh token requests come same time #3207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sawadashota
changed the title
sawadashota
changed the title
aeneasr
requested changes
Jul 28, 2022
persistence/sql/persister_oauth2.go
Outdated
| Exec()) | ||
| if err := p.Connection(ctx). | ||
| RawQuery(fmt.Sprintf("DELETE FROM %s WHERE signature=?", OAuth2RequestSQL{Table: table}.TableName()), signature). | ||
| Exec(); errors.Is(err, sql.ErrNoRows) { |
There was a problem hiding this comment.
This can never be true because Exec() is no longer wrapped in sqlcon.HandleError
persistence/sql/persister_oauth2.go
Outdated
| } else if err := sqlcon.HandleError(err); err != nil { | ||
| if errors.Is(err, sqlcon.ErrConcurrentUpdate) { | ||
| return errors.Wrap(fosite.ErrSerializationFailure, err.Error()) | ||
| } else if strings.Contains(err.Error(), "Error 1213") { // InnoDB Deadlock? |
There was a problem hiding this comment.
Could we handle this in sqlcon.HandleError instead :)
There was a problem hiding this comment.
fixed at 1ad6caa!
aeneasr
approved these changes
Jul 29, 2022
Signed-off-by: sawadashota <shota@sslife.tech>
Signed-off-by: sawadashota <shota@sslife.tech>
aeneasr
force-pushed
the
handle_delete_session_by_signature_error
branch
from
1ad6caa to
4574761
Compare
Codecov Report
@@ Coverage Diff @@
## master #3207 +/- ##
==========================================
- Coverage 79.55% 79.31% -0.24%
==========================================
Files 112 111 -1
Lines 7971 8077 +106
==========================================
+ Hits 6341 6406 +65
- Misses 1225 1258 +33
- Partials 405 413 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. |
grantzvolsky
pushed a commit
that referenced
this pull request
Jul 31, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
grantzvolsky
pushed a commit
that referenced
this pull request
Aug 1, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
aeneasr
pushed a commit
that referenced
this pull request
Aug 1, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
aeneasr
pushed a commit
that referenced
this pull request
Aug 18, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
aeneasr
pushed a commit
that referenced
this pull request
Sep 5, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
aeneasr
pushed a commit
that referenced
this pull request
Sep 7, 2022
…3207) Signed-off-by: sawadashota <shota@sslife.tech>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Handle server error when refresh token requests come same time.
Hydra usually handles this as
ErrInactiveToken. But sometimes, when requests come very bad timing, this will beErrServerErrorwith very poor error log ({msg: 'An error occurred', error: {debug: 'server_error', status: 'Internal Server Error'}}).As stack trace log (debug mode), it turns out that
Persister.deleteSessionBySignaturereturnssqlconn's error without any handling. If it'sforsite's error, fosite will handle error asErrInvalidRequestat RefreshTokenGrantHandler.handleRefreshTokenEndpointStorageError.StackTrace(debug mode)
Checklist
If this pull request addresses a security. vulnerability,
I confirm that I got green light (please contact security@ory.sh) from the maintainers to push the changes.
Further Comments