fix go-jose imports #605
Closed
fix go-jose imports #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Merged
|
I created a new branch for 0.9.x: https://github.com/ory/hydra/tree/v0.9.x - can you rebase against that? Also note that this might be an issue with fosite as well, go-jose is used there as well (version 1.0) so resolving this only here won't solve it properly (I think) |
|
I haven't had an issue with fosite so far, but yes it can't hurt to add a Gopkg.toml there either. I've rebased this as asked. |
|
This can be closed right? |
|
yes, it's included in #606 |
|
I made this change to master as well (and switched to dep) which will be released with #630 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch against v0.9.13, but there was no branch based on that at present, so I apologize for requesting this against master.
When using the hydra sdk in other go packages, there is a problem with the go-jose import that makes it impossible, unless the other package uses glide, to resolve the vendor issues such that hydra still builds and tests successfully while the package that imports it builds and tests successfully. This is because it uses the
github.com/square/go-joseimport while expecting the v1 version of go-jose which is supposed to be imported withgopkg.in/square/go-jose.v1.This patch fixes the imports so that go-jose v2 (which uses the
github.com/square/go-joseimport`) can be used instead and drops the v1 requirement from glide.