Support dep #606
Merged
Support dep #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 9, 2017 14:21
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
|
I see, use of dep makes sense, the idea is to transition at some point anyhow. However, I had some issues with dep on windows which is why it's not included yet. I'm however open to accepting this change. One thing though, could you add dep tests to travis.yml (similar to glide tests)? Also, here's a 0.9.x branch: https://github.com/ory/hydra/tree/v0.9.x |
added 2 commits
October 10, 2017 21:23
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
|
OK, based on v0.9.x and all glide and dep tests now pass |
|
Thank you! |
Closed
aeneasr
pushed a commit
that referenced
this pull request
Oct 25, 2017
* vendor: support dep (#606) * fix go-jose Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * add Gopkg.toml Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * add tests for dep Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * fix glide build Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * warden/groups: add ability to list all groups (#612) * add ability to list all groups Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * update based on review comments Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * a few more updates from review Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * ensure group lists dont return nil Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * support es256 Signed-off-by: Joshua Rubin <jrubin@zvelo.com> * update jwk tests Signed-off-by: Joshua Rubin <jrubin@zvelo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch against v0.9.13, and requires #605, but there was no branch based on that at present, so I apologize for requesting this against master.
This adds a Gopkg.toml file so that dep can be supported. You can continue to use glide if you keep the Gopkg.toml up-to-date too. The reason that this is useful, for packages that use the hydra sdk, is that dep will recursively resolve dependencies using the Gopkg.toml file.
Right now, we have to add overrides for each of hydra's dependencies which is less than ideal.