Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuration of same-site cookie #257

Closed
aeneasr opened this issue Feb 18, 2020 · 3 comments · Fixed by #303
Closed

Allow configuration of same-site cookie #257

aeneasr opened this issue Feb 18, 2020 · 3 comments · Fixed by #303
Assignees
@zepatrik
Labels
package/session Affects session components
Milestone
v0.2.0-alpha.1

Comments

@aeneasr
Copy link
Member

aeneasr commented Feb 18, 2020

Describe the bug

It's currently not possible to set SameSite for session cookies. This should be possible.
@aeneasr aeneasr added the package/session Affects session components label Feb 18, 2020
@aeneasr aeneasr added this to the v0.1.1-alpha.1 milestone Feb 18, 2020
@zepatrik
Copy link
Member

What should the config key and path be? selfservice.login.request_cookie_same_site ? (and with all the other requests)

@aeneasr
Copy link
Member Author

aeneasr commented Mar 16, 2020

i think this should be handled globally in one config key for all cookies

@zepatrik
Copy link
Member

security.session.cookie.same_site

@zepatrik zepatrik mentioned this issue Mar 20, 2020
Merged
aeneasr added a commit that referenced this issue Mar 21, 2020
@zepatrik @aeneasr
feat: allow configuring same-site for session cookies (#303)
2eb2054 
It is now possible to set SameSite for the session cookie via the key `security.session.cookie.same_site`.

Closes #257

Co-authored-by: aeneasr <aeneas@ory.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zepatrik zepatrik

Labels
package/session Affects session components
Projects
None yet
Milestone
v0.2.0-alpha.1
Development

Successfully merging a pull request may close this issue.

feat: allow configuring same-site for session cookies ory/kratos
2 participants
@aeneasr @zepatrik