feat: allow configuring same-site for session cookies #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeneasr
reviewed
Mar 21, 2020
| @@ -370,3 +373,15 @@ func (p *ViperProvider) SelfServiceVerificationReturnTo() *url.URL { | |||
| func (p *ViperProvider) SelfServicePrivilegedSessionMaxAge() time.Duration { | |||
| return viperx.GetDuration(p.l, ViperKeySelfServicePrivilegedAuthenticationAfter, time.Hour) | |||
| } | |||
|
|
|||
| func (p *ViperProvider) SessionSameSiteMode() http.SameSite { | |||
| switch viperx.GetString(p.l, ViperKeySessionSameSite, "Lax") { | |||
There was a problem hiding this comment.
Let's make this case-insensitive!
There was a problem hiding this comment.
I thought we might respect the standard https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#SameSite
but is not really necessary
There was a problem hiding this comment.
Yeah I guess you're right, I mean it is being validated in the JSON Schema so it would be easily detectable. I think both ways are ok. What do you think?
There was a problem hiding this comment.
Let's just leave it this way, validation will anyway only allow the capitalized version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
closes #257
Proposed changes
It is now possible to set SameSite for the session cookie via the key
security.session.cookie.same_site.