Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: response handling for session store (bearer + cookie) #916

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

fix: response handling for session store (bearer + cookie) #916

wants to merge 11 commits into from

Commits on Jun 23, 2022

  1. Fix: response lost 

    I am not sure where to start, we run against ory platform and noticed
that the response "from" oathkeeper did not contain a subject when it
got to the backend service.

I managed to find out that the "body" in `forwardRequestToSessionStore()`
was nil/empty in some cases and the gjson calls failed silently.

I started log.Printf() debugging in these two service files and simplified
the code a bit to make it more readable. And that seemed to have fixed it.
    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    eeaabae View commit details
    Browse the repository at this point in the history

  2. Chore: include tag/commit (instead of master)

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    3994e9a View commit details
    Browse the repository at this point in the history

  3. Fix: gzip handling 

    Related: ory#836
    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    16baaf1 View commit details
    Browse the repository at this point in the history

  4. Fix: gzip handling 

    Related: ory#836
    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    2e1fd65 View commit details
    Browse the repository at this point in the history

  5. Chore: more generic error responses

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    eeeb41f View commit details
    Browse the repository at this point in the history

  6. Chore: introduce logger

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    1385af7 View commit details
    Browse the repository at this point in the history

  7. Chore: add test for error when subject is empty

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    f46521a View commit details
    Browse the repository at this point in the history

  8. Chore: add a trace to the error

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    d6c0511 View commit details
    Browse the repository at this point in the history

  9. Chore: address CR

    @till
    till committed Jun 23, 2022
    Configuration menu
    Copy the full SHA
    bcb5dea View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2023

  1. Merge remote-tracking branch 'upstream/master' into debug-build

    @till
    till committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    e6a0e44 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Fix: grpc middleware test 

    - refactors test helpers into middleware_test.go
- provides a "complete" response from the test server
- complete response is necessary in order to provide subject (to allow the request)
    @till
    till committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    4a4fd23 View commit details
    Browse the repository at this point in the history