Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to docker compose subcommand #5560

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

perlpunk
Copy link
Contributor

@perlpunk perlpunk commented Apr 2, 2024

The docker-compose tool isn't maintained anymore and should be replaced by the docker compose subcommand:
https://docs.docker.com/compose/migrate/

docker-compose: command not found

@Martchus
Copy link
Contributor

Martchus commented Apr 2, 2024

The test failed with:

-- Blocking request (http://nginx:9526/api/v1/jobs)
-- Connect cb13661a1d583e5cc003debb95f4aaf9 (http://nginx:9526)
Connection refused
Error executing a job
webui-1  | Waiting for DB creation

I retried the test run but maybe it is related to this change.

@perlpunk
Copy link
Contributor Author

perlpunk commented Apr 2, 2024

I'm debugging this

@perlpunk
Copy link
Contributor Author

perlpunk commented Apr 2, 2024

export COMPOSE_COMPATIBILITY=1 at the top of tools/test_containers_compose did not help

The docker-compose tool isn't maintained anymore and should be replaced
by the docker compose subcommand:
https://docs.docker.com/compose/migrate/

    docker-compose: command not found

We need the --compatibility flag because it's failing without and we still
need to find the reason.
@perlpunk
Copy link
Contributor Author

perlpunk commented Apr 2, 2024

Adding --compatibility worked. We can use this as a temporary workaround to get tests passing.

@perlpunk
Copy link
Contributor Author

perlpunk commented Apr 2, 2024

https://docs.docker.com/compose/migrate/#service-container-names suggests that the changed container names (- instead of _) are the problem. I currently don't see a place where we use the container names explicitly though.

@mergify mergify bot merged commit ddbfb73 into os-autoinst:master Apr 2, 2024
35 checks passed
@perlpunk perlpunk deleted the docker-compose branch April 2, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants