Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump prettier to 3.2.5 along with eslint-plugin-prettier 5.0.0.0 #5561

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Bump prettier to 3.2.5 along with eslint-plugin-prettier 5.0.0.0 #5561

merged 2 commits into from
Apr 3, 2024

Conversation

kalikiana
Copy link
Member

Bumping prettier from 2.3.2 to 3.2.5 as proposed by #5518 requires an update of eslint-plugin-prettier and an according style change.

@kalikiana
Copy link
Member Author

Note the compose failure will be addressed by #5560

@perlpunk
Copy link
Contributor

perlpunk commented Apr 2, 2024

https://app.circleci.com/pipelines/github/os-autoinst/openQA/13276/workflows/8acb3c60-660c-499d-a074-c03c5e5f86ad/jobs/124181

[14:54:07] t/45-make-update-deps.t ................................... 1/? 
#   Failed test 'No changed files after 'make update-deps''
#   at t/45-make-update-deps.t line 16.
#  M package-lock.json
# Looks like you failed 1 test of 2.
[14:54:07] t/45-make-update-deps.t ................................... Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2 subtests

I can't reproduce that locally with this PR.
But maybe it would be good to rebase the branch.

@perlpunk
Copy link
Contributor

perlpunk commented Apr 2, 2024

Ah, I see. If I run make node_modules, I get a diff too.
So maybe you just need to add the changed package-lock.json.

dependabot bot and others added 2 commits April 3, 2024 08:59
@dependabot @kalikiana
Bump prettier from 2.3.2 to 3.2.5
f46fff1 
Bumps [prettier](https://github.com/prettier/prettier) from 2.3.2 to 3.2.5.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@2.3.2...3.2.5)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@kalikiana
Update eslint-plugin-prettier to 5.0.0
81b30b9
@mergify mergify bot merged commit 6990dcd into os-autoinst:master Apr 3, 2024
36 checks passed
@kalikiana kalikiana self-assigned this Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Martchus Martchus Martchus approved these changes

@okurz okurz okurz approved these changes

Assignees

@kalikiana kalikiana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalikiana @perlpunk @okurz @Martchus