Fix Pin Planner crash (#1710)

* Fix Pin Planner crash

* Incremented patch version

---------

Co-authored-by: alaindargelas <alaindargelas@users.noreply.github.com>

CMakeLists.txt

@@ -39,7 +39,7 @@ set(VERSION_MINOR 0)
 # Add the spdlog directory to the include path
 include_directories(${CMAKE_CURRENT_SOURCE_DIR}/third_party/spdlog/include ${CMAKE_CURRENT_SOURCE_DIR}/third_party/exprtk ${CMAKE_CURRENT_SOURCE_DIR}/third_party/scope_guard) 
 
-set(VERSION_PATCH 431)
+set(VERSION_PATCH 432)
 
 
 option(

src/MainWindow/main_window.cpp

@@ -897,9 +897,7 @@ void MainWindow::createMenus() {
 
  toolsMenu = menuBar()->addMenu("&Tools");
  toolsMenu->addAction(ipConfiguratorAction);
-#ifndef PRODUCTION_BUILD
  toolsMenu->addAction(pinAssignmentAction);
-#endif
  toolsMenu->addAction(programmerAction);
  toolsMenu->addAction(eFpgaConfigurator);
 
@@ -914,9 +912,7 @@ void MainWindow::createMenus() {
  helpMenu->addAction(compressProjectAction);
 
  preferencesMenu->addAction(defualtProjectPathAction);
-#ifndef PRODUCTION_BUILD
  preferencesMenu->addAction(pinPlannerPinNameAction);
-#endif
  preferencesMenu->addAction(editorSettingsAction);
  preferencesMenu->addAction(showWelcomePageAction);
  preferencesMenu->addAction(stopCompileMessageAction);

src/PinAssignment/PinAssignmentBaseView.cpp

@@ -109,7 +109,9 @@ void PinAssignmentBaseView::insertCombo(QComboBox *combo,
 }
 
 void PinAssignmentBaseView::removeFromList(QObject *obj) {
- m_allCombo.remove(qobject_cast<QComboBox *>(obj));
+ // Bug: qobject_cast<QComboBox*> returns 0 now the type is ComboBox
+ // Use brute force cast for now.
+ m_allCombo.remove((QComboBox *)obj);
 }
 
 } // namespace FOEDAG