Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pin Planner crash #1710

Merged
merged 2 commits into from
Sep 28, 2024
Merged

Fix Pin Planner crash #1710

merged 2 commits into from
Sep 28, 2024

Conversation

alaindargelas
Copy link
Contributor

Motivate of the pull request

  • [x ] To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Bug: qobject_cast<QComboBox*> returns 0 now the type is ComboBox
Use brute force cast for now.

@alaindargelas alaindargelas merged commit 0e8942a into main Sep 28, 2024
2 of 3 checks passed
@alaindargelas alaindargelas deleted the fix_pin_planner_crash branch September 28, 2024 05:13
Copy link

codecov bot commented Sep 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 14.46%. Comparing base (daf2e2c) to head (57d20a1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/PinAssignment/PinAssignmentBaseView.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1710   +/-   ##
=======================================
  Coverage   14.46%   14.46%           
=======================================
  Files         478      478           
  Lines       63819    63819           
  Branches    26088    26116   +28     
=======================================
  Hits         9230     9230           
- Misses      53333    53344   +11     
+ Partials     1256     1245   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant