Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in resource checking #1686

Merged
merged 3 commits into from
Aug 27, 2024
Merged

Fix bug in resource checking #1686

merged 3 commits into from
Aug 27, 2024

Conversation

chungshien-chai
Copy link
Collaborator

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

The change split the root bank resource into smaller detail: A or B, CORE or CDR

  • This will allow better root bank resource utilization

What does this pull request change?

Which part of the code base require a change

  • Library:
  • Plug-in:
  • Engine
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

Attention: Patch coverage is 58.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 14.80%. Comparing base (f42d454) to head (1783698).
Report is 1 commits behind head on main.

Files Patch % Lines
src/Configuration/ModelConfig/ModelConfig_IO.cpp 57.14% 1 Missing and 5 partials ⚠️
...figuration/ModelConfig/ModelConfig_IO_resource.cpp 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1686      +/-   ##
==========================================
- Coverage   14.81%   14.80%   -0.02%     
==========================================
  Files         480      480              
  Lines       63842    63849       +7     
  Branches    26167    26052     -115     
==========================================
- Hits         9459     9451       -8     
+ Misses      53162    53150      -12     
- Partials     1221     1248      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alaindargelas alaindargelas merged commit a193fab into main Aug 27, 2024
35 checks passed
@alaindargelas alaindargelas deleted the foedag-io branch August 27, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants