Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge libsingular-julia back into Singular.jl #657

Merged
merged 122 commits into from
Jun 7, 2023

Conversation

fingolfin
Copy link
Member

This imports the history from https://github.com/oscar-system/libsingular-julia into this repository, in preparation for PR #639.

I tried to stich back the history in such a way that "git blame" and similar work seamlessly.

thofma and others added 30 commits June 7, 2023 00:05
* add id_LiftStd

* fix: id_LiftStd

Co-authored-by: thofma <thofma@gmail.com>
* "fix" CmakeFile and add a build.jl

which is not perfect (I don;t know what the conventions are)
but it illustrates what to do

* Update build.jl

Co-authored-by: thofma <thofma@gmail.com>
- version with/out syzygies
- add complete_reduction
... it is identical to n_Delete
... by letting it return its result, instead of void.
…r-system#10)

* First try on conversion of Singular.jl arrays to Singular lists

Added a first try on conversion of Singular.jl arrays to Singular lists in order to be able to call more Singular libraries in Singular.jl

* Fixed type. Changed name of function.
* getting and setting the minpoly

* fix minpoly functions
To use this, you can start it inside the `libsingular-julia` directory via

    julia --project=. run.jl

and it will first install a few Julia packages, then build all C++ code, and
finally start a Julia session with an artifact override in place which ensures
that `libsingular_julia_jll` picks up the copy of the C++ code that was just compiled.

To verify the override is in effect, check the value of `libsingular_julia_jll.artifact_dir`.

You can now e.g. `Pkg.add("Singular")` and then `Pkg.test("Singular")`; or do
`using Singular` to test Singular interactively.
put all julia 1.6 tests to includes to avoid weird matrix-includes mixup
tthsqe12 and others added 26 commits June 7, 2023 00:05
Don't corrupt the ring data. Also, incidentally use lex.
@fingolfin fingolfin requested a review from benlorenz June 6, 2023 22:12
Copy link
Member

@benlorenz benlorenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the history back in, blame and log look reasonable.

@fingolfin fingolfin merged commit 14fdb93 into oscar-system:master Jun 7, 2023
@fingolfin fingolfin deleted the mh/merge-libsingular branch June 7, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants