You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the context of PR #22, it was noted that the is hardcoded to 'test-gke-fleet-host-tf64-sb' within the module in . This limits the flexibility of the test configuration and could potentially affect the ability to test in different environments.
Suggestion:
Parameterize the to allow dynamic testing environments, enhancing the module's flexibility and usability.
Suggested change:
project_id = 'test-gke-fleet-host-tf64-sb'
project_id = var.project_id
This change would require adding a corresponding variable in the variables definition and ensuring it's passed correctly in test configurations.
In the context of PR #22, it was noted that the is hardcoded to 'test-gke-fleet-host-tf64-sb' within the module in . This limits the flexibility of the test configuration and could potentially affect the ability to test in different environments.
Suggestion:
Parameterize the to allow dynamic testing environments, enhancing the module's flexibility and usability.
Suggested change:
This change would require adding a corresponding variable in the variables definition and ensuring it's passed correctly in test configurations.
Related PR: #22
Comment: #22 (comment)
The text was updated successfully, but these errors were encountered: