Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameterize project_id in test module for GKE fleet management tests #26

Closed
coderabbitai bot opened this issue Feb 17, 2024 · 0 comments · Fixed by #27
Closed

Parameterize project_id in test module for GKE fleet management tests #26

coderabbitai bot opened this issue Feb 17, 2024 · 0 comments · Fixed by #27
Assignees

Comments

@coderabbitai
Copy link

coderabbitai bot commented Feb 17, 2024

In the context of PR #22, it was noted that the is hardcoded to 'test-gke-fleet-host-tf64-sb' within the module in . This limits the flexibility of the test configuration and could potentially affect the ability to test in different environments.

Suggestion:
Parameterize the to allow dynamic testing environments, enhancing the module's flexibility and usability.

Suggested change:

  • project_id = 'test-gke-fleet-host-tf64-sb'
  • project_id = var.project_id

This change would require adding a corresponding variable in the variables definition and ensuring it's passed correctly in test configurations.

Related PR: #22
Comment: #22 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant