Rename Istio gateway DNS variable

[brettcurtis]

[skip actions]

Summary by CodeRabbit

• Refactor
  • Simplified Istio gateway domain names configuration by renaming variables across global and regional settings.
• Chores
  • Updated documentation to reflect variable name changes.
  • Adjusted project naming in infrastructural configuration files.

[coderabbitai]

Walkthrough

This update streamlines the configuration of Istio gateway domain names and managed certificate resource creation by renaming a Terraform variable across global and regional configurations. Additionally, it adjusts the project setup in the infracost.yml file, enhancing clarity and organization.

Changes

Files	Change Summary
global/README.md, global/variables.tf, global/locals.tf, global/main.tf	Renamed Terraform variable from istio_gateway_mci_dns to istio_gateway_dns.
infracost.yml	Removed gke_fleet_host_shared project entry; renamed gke_fleet_host_global.
regional/istio/README.md, regional/istio/variables.tf, regional/istio/locals.tf, regional/istio/main.tf	Renamed variable ingress_istio_gateway_dns to istio_gateway_dns.
test/fixtures/gke_fleet_host/global/main.tf, test/fixtures/gke_fleet_host/regional_istio/main.tf	Renamed variable istio_gateway_mci_dns to istio_gateway_dns.

Related issues

• Parameterize project_id in test module for GKE fleet management tests #26: This PR does not directly address the issue's objective of parameterizing project_id in test modules for GKE fleet management tests.
• Simplify adding a new internal customer feature request (Terraform root module) to the platform platform-google-cloud-landing-zone#1: Not directly related as this PR focuses on Istio gateway configuration and does not involve adding new internal customer feature requests or enabling Google Artifact Registry.
• osinfra-io/github-organization-discussions#6 & Simplify onboarding for new teams consuming Kubernetes clusters platform-google-cloud-kubernetes#1: These issues focus on simplifying onboarding and improving workflows for Kubernetes cluster consumption, which is indirectly related through the streamlined Istio gateway configuration but does not directly address the stated objectives.
• Duplicate object key on identity groups when service account name is the same google-cloud-hierarchy#172: Unrelated; this PR focuses on resolving a "Duplicate object key" error in a different context.
• Add or update custom IAM role google-cloud-hierarchy#181: Unrelated; the PR does not involve adding or updating IAM roles for Kubernetes resource deployment.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: .coderabbit.yaml

Commits

Files that changed from the base of the PR and between 491d309 and fa0884c.

Files selected for processing (11)

• global/README.md (1 hunks)
• global/locals.tf (1 hunks)
• global/main.tf (1 hunks)
• global/variables.tf (1 hunks)
• infracost.yml (1 hunks)
• regional/istio/README.md (1 hunks)
• regional/istio/locals.tf (1 hunks)
• regional/istio/main.tf (1 hunks)
• regional/istio/variables.tf (1 hunks)
• test/fixtures/gke_fleet_host/global/main.tf (1 hunks)
• test/fixtures/gke_fleet_host/regional_istio/main.tf (1 hunks)

Additional comments: 11

global/locals.tf (1)

• 10-10: The change from var.istio_gateway_mci_dns to var.istio_gateway_dns aligns with the PR's objective and is correctly implemented here.

regional/istio/locals.tf (1)

• 13-13: The update from var.ingress_istio_gateway_dns to var.istio_gateway_dns is correctly implemented and aligns with the PR's objective.

global/variables.tf (1)

• 20-21: The renaming of the variable and the updated description are clear and align with the PR's objective.

test/fixtures/gke_fleet_host/global/main.tf (1)

• 9-9: The renaming of the variable in the test fixture aligns with the PR's objective and is correctly implemented.

regional/istio/variables.tf (1)

• 36-37: The renaming of the variable and the updated description are clear and align with the PR's objective.

infracost.yml (1)

• 21-26: > 📝 NOTE

This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [1-1]

The adjustments in the infracost.yml file, while not directly related to the variable renaming, are part of an ongoing effort to refine and optimize project configurations.

test/fixtures/gke_fleet_host/regional_istio/main.tf (1)

• 59-59: The renaming of the variable in the test fixture aligns with the PR's objective and is correctly implemented.

regional/istio/README.md (1)

• 46-46: The documentation update aligns with the PR's objective and accurately reflects the variable renaming.

global/README.md (1)

• 41-47: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [44-55]

The documentation has been updated to reflect the new variable name istio_gateway_dns in the Inputs section, which aligns with the PR objectives. However, the Outputs section still references istio_gateway_mci_global_address and istio_gateway_mci_ssl_certificate_name. Please confirm if these outputs are correctly named or if they should also be updated to reflect the new naming convention.

regional/istio/main.tf (1)

• 16-16: The update to use var.istio_gateway_dns in the google_dns_record_set resource is correctly implemented and aligns with the PR objectives for renaming the variable.

global/main.tf (1)

• 53-53: The update to use var.istio_gateway_dns in the google_dns_record_set resource is correctly implemented and aligns with the PR objectives for renaming the variable.