Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Berlin aerial photography provided by the city of Berlin #480

Closed
tordans opened this issue May 2, 2018 · 8 comments
Closed

Add Berlin aerial photography provided by the city of Berlin #480

tordans opened this issue May 2, 2018 · 8 comments
Labels

Comments

@tordans
Copy link
Contributor

tordans commented May 2, 2018

The city of Berlin has images that are a lot better than what Bing and such provides. It would be aweseome to have them as a layer in iD Editor and such. Ideally as the default layer for that region.

There are two data layers, I think both are interesting. Layer one should have priority and be the default image layer when opening iD Editor in Berlin. Layout two could be an optional layer (like "Esri" vs "Esri (Clarity)").

URL of the imagery

This is all I know ATM

Layer 1:

Layer 2 Infrared:

Two letter country code

DE

Desired layer name and attribution

Layer 1:

    "properties": {
        "attribution": {
            "required": true,
            "text": "Geoportal Berlin / Digitale farbige Orthophotos 2017 (DOP20RGB)",
            "url": "https://daten.berlin.de/datensaetze/digitale-farbige-orthophotos-2017-dop20rgb-wms-1"
        },
        "license_url": "https://wiki.openstreetmap.org/wiki/Geoportal_Berlin",
        "name": "Luftbilder Berlin 2017 (DOP20RGB)",
    },

Layer 2 Infrared:

    "properties": {
        "attribution": {
            "required": true,
            "text": "Geoportal Berlin / Digitale Color-Infrarot-Orthophotos 2016 (DOP20CIR) ",
            "url": "https://daten.berlin.de/datensaetze/digitale-color-infrarot-orthophotos-2016-dop20cir-wms"
        },
        "license_url": "https://wiki.openstreetmap.org/wiki/Geoportal_Berlin",
        "name": "Luftbilder Berlin 2016 Infrarot (DOP20CIR)",
    },

License

Is the license compatible with OSM?

  • I don't know Yes, see discussion and links below
  • I asked the local OSM Community and will update with feedback.
  • I asked the local OKFN (Open Data) Community and will update with feedback.
  • I can say, that JOSM seems to to add the Berlin Images in their macOS Installation package as a default layout(?)

Icon

(optional)

  • TODO

Bounding polygon

Sidenote: The full map on the official website: http://fbinter.stadt-berlin.de/fb/index.jsp?loginkey=zoomStart&mapId=k_luftbild2016_rgb@senstadt&bbox=363892,5802743,419400,5837906

@tordans tordans changed the title Add Berlin Add Berlin aerial photography provided by the city of Berlin May 2, 2018
@tyrasd
Copy link
Member

tyrasd commented May 2, 2018

regarding the license: The page on the osm wiki (also linked from JOSM's background layers page) https://wiki.openstreetmap.org/wiki/Geoportal_Berlin claims that the service is OSM-compatible:

Geodaten unter OSM-kompatiblen Nutzungsbedingungen

Die Berliner Senatsverwaltung für Stadtentwicklung und Umwelt (SenStadtUm) stellt seit dem 1. Oktober 2013 Geodaten unter an CC-BY angelehnten Nutzungsbedingungen bereit. Die in § 2 geforderte erkennbare und in optischem Zusammenhang Einbindung der Quellenverweise wird lt. SenStadtUm nur gefordert, wenn die Geodaten einen überwiegenden Anteil im Folgewerk haben. Wenn die veränderten Geodaten nur einen untergeordneten Anteil an dem Folgeprodukt haben, dann kann der Quellenvermerk für abgeleitete Werke auch an einer anderen Stelle (also hier) angebracht werden.

So, I believe it should be ok to be include it in this repository as is. But it would be awesome if you could confirm this with the local community!

@tyrasd
Copy link
Member

tyrasd commented May 2, 2018

Regarding the boundary polygon: Maybe we can use the one from the entry in JOSM's list (looks like this), or you can try to create a better one (see our FAQ's).

@tordans
Copy link
Contributor Author

tordans commented May 11, 2018

@tyrasd what next steps would you require to push this forward? The wiki pages seems clear to me. Is it required to get an explizit email from the city? Are there drafts / previous emails that I could use?
Thanks

@tordans
Copy link
Contributor Author

tordans commented May 12, 2018

The general wiki page and also the detailed wiki page go on saying, that the source tag should be used for attribution like Geoportal Berlin / [Title Of Dataset].

So an example for DOP20RGB would(?) be

Geoportal Berlin / Digitale farbige Orthophotos 2017 (DOP20RGB)

So if we adjust this to use the imagery_used tag instead, the attribution should be fine.

The iD Editor (Example Changeset) and also the (new) GoMap-App (Example Changeset) already set the imagery_used tag automatically based on the name that is provided in this layer index.

IMO all requirements are matched to add the data.

Update: I updated the Issue-Description to match this information.

@grischard
Copy link
Collaborator

@tordans
Copy link
Contributor Author

tordans commented May 14, 2018

@grischard thanks – and yes, that is also the basis for the wiki-page which in turn was the basis for my suggestion at #480 (comment) and my update of the issue description.

@tordans
Copy link
Contributor Author

tordans commented Jun 10, 2018

@tyrasd, @grischard what next steps would you require to push this forward? The wiki pages seems clear to me and allow adding the layer. I updated the issue description to reflect what I currently know.

What else is required? In what form?

Thanks

@grischard
Copy link
Collaborator

grischard commented Jun 18, 2018

I'll integrate the ones JOSM has. It'd be cool to have all the layes from codefor.de - a PR would be best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants