Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change tile server for berlin images #515

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Change tile server for berlin images #515

merged 1 commit into from
Jun 28, 2018

Conversation

tordans
Copy link
Contributor

@tordans tordans commented Jun 28, 2018

This is a follow up to #480.

It is awesome to have the Berlin aerial photography right in iD now.
However, the image server by the city seems to be a bit slow.

Speed comparison

City OKFN
bildschirmfoto 2018-06-28 um 19 21 06 ~6s waiting, URL bildschirmfoto 2018-06-28 um 19 21 16 ~37ms waiting, URL

The OKFN source is based on https://tiles.codefor.de/ / https://codefor.de/projekte/2018-04-09-fis-broker.html

Note: The 2011 data are not available with tiles.codefor, so I left them be.

Todos

  • Can someone validate that this changes will work?
  • I wonder if we need the "required": true attribute for the attribution part, other datasets have it; what does it do?

- change tile server url + url-type
- fix typo for name
@tordans tordans mentioned this pull request Jun 28, 2018
@bhousel
Copy link
Member

bhousel commented Jun 28, 2018

Can someone validate that this changes will work?

These changes look good to me - the best way to test is to open iD and paste the url into the "custom" . I tried this for the 2017 layer and it does load much faster.

I wonder if we need the "required": true attribute for the attribution part, other datasets have it; what does it do?

I think it just means that an editor is required to show the attribution line.

@bhousel bhousel merged commit 8fdc156 into osmlab:gh-pages Jun 28, 2018
@bhousel
Copy link
Member

bhousel commented Jun 28, 2018

I switched from {z} to {zoom}, removed the available_projections (not applicable for tms sources) and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants